-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Patch 0001: Eliminate possible NULL-dereference in pam_check_user_search Fixes https://fedorahosted.org/sssd/ticket/719
Patch 0002: Add missing break statement to sss_hash_create Fixes https://fedorahosted.org/sssd/ticket/720 Patch 0003: Prevent uninitialized value error in monitor_quit Fixes https://fedorahosted.org/sssd/ticket/724 - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk0H0Q4ACgkQeiVVYja6o6NAVACglsXyMjOLbMX2JX6a7GZ90uxA sx0An2N6XwtIaGITNgx7EGiJh6McQT5Q =4QdT -----END PGP SIGNATURE-----
From aeb3a2a386133a5d6714230b7029536664f88d34 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher <[email protected]> Date: Tue, 14 Dec 2010 14:44:44 -0500 Subject: [PATCH 1/3] Eliminate possible NULL-dereference in pam_check_user_search https://fedorahosted.org/sssd/ticket/719 --- src/responder/pam/pamsrv_cmd.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/responder/pam/pamsrv_cmd.c b/src/responder/pam/pamsrv_cmd.c index 27a6195d68afc8b8fa37c71b7d389947a9316bfd..8b6420748ed960453f30592c8970732a7f31d72b 100644 --- a/src/responder/pam/pamsrv_cmd.c +++ b/src/responder/pam/pamsrv_cmd.c @@ -848,6 +848,13 @@ static int pam_check_user_search(struct pam_auth_req *preq) return EOK; } + if (!dom) { + /* Ensure that we don't try to check a provider without a domain, + * since this will cause a NULL-dereference below. + */ + preq->check_provider = false; + } + if (preq->check_provider) { /* dont loop forever :-) */ -- 1.7.3.3
From 63ec771b4ec747090b996b7c63aeee78c4bdd563 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher <[email protected]> Date: Tue, 14 Dec 2010 14:46:37 -0500 Subject: [PATCH 2/3] Add missing break statement to sss_hash_create https://fedorahosted.org/sssd/ticket/720 --- src/util/util.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/util/util.c b/src/util/util.c index 772a8b73f3a99d17b9a1cb9bc5d6543ef78ebc87..67f9880dc88ecef37c0d3b338d2bd115f5a18bec 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -505,6 +505,7 @@ errno_t sss_hash_create(TALLOC_CTX *mem_ctx, case HASH_ERROR_NO_MEMORY: ret = ENOMEM; + break; default: ret = EIO; } -- 1.7.3.3
From af18b541925b47df37ec8d02dda1b8c04c671ea3 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher <[email protected]> Date: Tue, 14 Dec 2010 14:48:37 -0500 Subject: [PATCH 3/3] Prevent uninitialized value error in monitor_quit https://fedorahosted.org/sssd/ticket/724 --- src/monitor/monitor.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/monitor/monitor.c b/src/monitor/monitor.c index 7727d09b98594c0dc5396cdee81ad3ce87e426c1..bee27e8b9667360c65d1d164020e4a1872e29cc3 100644 --- a/src/monitor/monitor.c +++ b/src/monitor/monitor.c @@ -1202,6 +1202,7 @@ static void monitor_quit(struct tevent_context *ev, svc->name, svc->pid, strerror(error))); } + error = 0; do { errno = 0; pid = waitpid(svc->pid, &status, WNOHANG); -- 1.7.3.3
0001-Eliminate-possible-NULL-dereference-in-pam_check_use.patch.sig
Description: PGP signature
0002-Add-missing-break-statement-to-sss_hash_create.patch.sig
Description: PGP signature
0003-Prevent-uninitialized-value-error-in-monitor_quit.patch.sig
Description: PGP signature
_______________________________________________ sssd-devel mailing list [email protected] https://fedorahosted.org/mailman/listinfo/sssd-devel
