-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Not all calls to do_pam_conversation() pass in a return value for the _answer argument (notably, all PAM_TEXT_INFO calls). So if we receive a PAM_TEXT_INFO message, we segfault. This burned me when I was trying to log in offline with pam_verbosity=3 Pushed to master under the one-liner and unbreak-the-build rules. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk0KRIcACgkQeiVVYja6o6MfrACgnHbHfMnm0UjY6KzD6UrGxbLX EScAoJK+0vKbsVxZwxRbVw1ctwI/KbDh =jyfZ -----END PGP SIGNATURE-----
From 197680b1bc80abbfbb733fbb2082fe59510a6960 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher <[email protected]> Date: Thu, 16 Dec 2010 11:51:00 -0500 Subject: [PATCH] Fix segfault for PAM_TEXT_INFO conversations --- src/sss_client/pam_sss.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/sss_client/pam_sss.c b/src/sss_client/pam_sss.c index 539acb0b1d9662a2fc74cdad812d6fb42fcef2e1..f35f06f261434f70deebda77b84d564f4da0213a 100644 --- a/src/sss_client/pam_sss.c +++ b/src/sss_client/pam_sss.c @@ -413,7 +413,7 @@ static int do_pam_conversation(pam_handle_t *pamh, const int msg_style, } } while (state != SSS_PAM_CONV_DONE); - *_answer = answer; + if(answer) *_answer = answer; return PAM_SUCCESS; failed: -- 1.7.3.3
0001-Fix-segfault-for-PAM_TEXT_INFO-conversations.patch.sig
Description: PGP signature
_______________________________________________ sssd-devel mailing list [email protected] https://fedorahosted.org/mailman/listinfo/sssd-devel
