-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/20/2010 06:16 AM, Sumit Bose wrote: > On Fri, Dec 17, 2010 at 04:13:18PM -0500, Stephen Gallagher wrote: > Patch 0001: Nack > I'd rather that you split out sss_hash_create() and > sss_hash_create_ex(). The sss_hash_create() should omit the delete > callback information. I would prefer sss_hash_create() to be the common > case. > > Patch 0002: Nack > Will need to be updated to match the above change > Fix the patch commit comment to say "principal" rather than username > Otherwise, the patch looks good. > > >> New patches attached.
Ack to both. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk0PaMQACgkQeiVVYja6o6OHQQCfdqTdbJFCHOlbTvbMQ97pqeW0 5LUAn0KCLMt9u+9CKOiBXIhYqhSvMa0M =RUyx -----END PGP SIGNATURE----- _______________________________________________ sssd-devel mailing list [email protected] https://fedorahosted.org/mailman/listinfo/sssd-devel
