-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 03/30/2011 04:47 AM, Jan Zelený wrote: > Stephen Gallagher <sgall...@redhat.com> wrote: >> We were not fully compliant with section 5.3 of RFC 2307 which >> states: >> >> An account's GECOS field is preferably determined by a value of the >> gecos attribute. If no gecos attribute exists, the value of the cn >> attribute MUST be used. (The existence of the gecos attribute allows >> information embedded in the GECOS field, such as a user's telephone >> number, to be returned to the client without overloading the cn >> attribute. It also accommodates directories where the common name >> does not contain the user's full name.) >> >> >> Fixes https://fedorahosted.org/sssd/ticket/703 > > Ack, just one little nitpick: line > > + if (el->num_values == 0) gecos = NULL; > > is redundant. >
Redundancy removed. Redundancy removed. Pushed to master and sssd-1-5. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk2TLloACgkQeiVVYja6o6OdPgCdFOSzG0c7zvdpEMOpqAwzW+Hm g4MAn2y62495VE5INxtIyfaRwm1Av8qq =KHOp -----END PGP SIGNATURE----- _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
