On Mon, 2011-04-25 at 08:04 -0400, Stephen Gallagher wrote: > On Thu, 2011-04-21 at 14:13 +0200, Jan Zelený wrote: > > > On Thu, 2011-04-21 at 12:30 +0200, Jan Zelený wrote: > > > > > Nack. > > > > > > > > > > You still have unchecked talloc_strdup() calls in this patch in > > > > > select_principal_from_keytab(). > > > > > > > > I don't think so, all talloc_strdup() calls in that function are checked > > > > for NULL output. But there was a tiny glitch, which is fixed in attached > > > > patch. > > > > > > > > Jan > > > > > > Sorry, I wrote talloc_strdup() and really meant talloc_asprintf(). Mea > > > culpa. > > > > Ah, that explains why I didn't find it, I looked at the output part of the > > function. Thanks for clarifying. > > > > > Could you please elaborate on the "tiny glitch" as well? > > > > Nothing serious, I just added code which frees already allocated outputs if > > one of them fails. > > > Ack
Pushed to master
signature.asc
Description: This is a digitally signed message part
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
