On Mon, Feb 20, 2012 at 05:25:06PM +0100, Jan Zelený wrote:
> > On Fri, Feb 10, 2012 at 02:21:01PM +0100, Jan Zelený wrote:
> > > > This will make confdb coherent with changes made in sysdb. Not using
> > > > context hierarchy will help detecting memory leaks if there are some.
> > > 
> > > Self nack on the first version, I skipped one call of confdb_get_int() in
> > > ssh module. New patch attached.
> > > 
> > > Jan
> > 
> > nack, you still need to free tmp_ctx even if you free its contents.
> 
> Thanks,
> Fixed patch in attachment.
> 
> Jan

Sorry, but still a nack. You're only freeing tmp_ctx in the failed:
label, you need to free it in both success and failure cases.
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to