On Wed, 2012-04-18 at 12:14 +0200, Jakub Hrozek wrote: > On Tue, Apr 17, 2012 at 03:23:33PM +0200, Jan Zeleny wrote: > > #114: > > There is no real issue in that code at this moment but it's only a lucky > > coincidence. If there was another element in group_attrs before member, the > > result would be SIGABRT. > > > > The patch is correct but not as bad as it seems, the mem_ctx parameter is > not used if the memory was previously allocated, only if ptr is NULL or > size is 0 (but it seems the man page for talloc_realloc says otherwise..) >
For the record, was that an ack? > > #115: > > Not really a memleak because of the memory hierarchy but I think it's nice > > to > > clean up memory when rewriting a pointer. > > Ack > > > > > Thanks > > Jan > > _______________________________________________ > sssd-devel mailing list > sssd-devel@lists.fedorahosted.org > https://fedorahosted.org/mailman/listinfo/sssd-devel
signature.asc
Description: This is a digitally signed message part
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
