On Mon, 2012-05-07 at 15:38 +0200, Jakub Hrozek wrote: > On Mon, May 07, 2012 at 02:37:00PM +0200, Stef Walter wrote: > > On 05/07/2012 02:12 PM, Jakub Hrozek wrote: > > > I only have two comments related to code style: > > > > > > + TALLOC_CTX *memctx; > > > + int n_etype_list; > > > + > > > + memctx = talloc_new (NULL); > > > > > > We usually call such memory context tmp_ctx so that it's clear it's a > > > short-lived context used only inside this function. > > > > > > + krb5_get_init_creds_opt_set_etype_list (&options, etype_list, > > > ^^^ > > > We don't use a space between a function name and the arguments list. > > > > Thanks. Fixed. Attached. > > > > Stef > > > > I missed one more thing, the second tmp_ctx used in > sss_krb5_read_etypes_for_keytab should have been allocated on top of > NULL, not memctx. > > Ack, but please squash in the attached one liner before pushing.
Squashed in and pushed to master.
signature.asc
Description: This is a digitally signed message part
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
