Stephen Gallagher <sgall...@redhat.com> wrote: > On Fri, 2012-06-15 at 19:53 +0200, Jan Zeleny wrote: > > Stephen Gallagher <sgall...@redhat.com> wrote: > > > All changes requested above have been made, including avoiding the > > > shadowing (in new patch 0003). > > > > > > I've completed my testing to my satisfaction with no additional changes > > > except those that Jan requested in his review. > > > > Nack, > > there is one more warning that you missed: > > > > src/providers/krb5/krb5_utils.c: In function ‘get_cc_be_ops’: > > src/providers/krb5/krb5_utils.c:570:5: warning: enumeration value > > ‘SSS_KRB5_TYPE_DIR’ not handled in switch [-Wswitch] > > > > Also please use new debug levels in your patch #0003 > > As discussed on IRC, I opted to conditionalize SSS_KRB5_TYPE_DIR in the > enum and then also conditionalize the code where we were detecting the > type from the input. My original idea was that we should detect and warn > that it's not supported, but I think that's out of scope for now. > > I also added a new patch adjusting the DEBUG macros as requested.
Ack to all four patches. Good job Jan
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
