On 08/21/2012 02:40 PM, Stephen Gallagher wrote:
On Tue, 2012-08-21 at 14:04 +0200, Pavel Březina wrote:
I found this warning while reviewing Michal's transaction patch.
It was introduced in 9356e8f50436724e985d9a8f5d4f2bc0f5b837bc and it is
visible with the following CFLAGS:
-m64 -mtune=generic -O3 -D_FORTIFY_SOURCE=2 -fstack-protector-all -Wall
-Wextra -Wno-sign-compare -Wno-unused-parameter
Nack. Please don't default to EOK. It makes it hard to keep track of it.
Instead, assign it EOK just before the "done:" label. (i.e. "If we got
here, we're OK")
Good point. New patch is attached.
From 2468ae7470ceb317de3b6ab26d9a30b7378cf776 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrez...@redhat.com>
Date: Tue, 21 Aug 2012 14:02:29 +0200
Subject: [PATCH] Remove compilation warning: ret may be uninitialized
---
src/providers/ldap/sdap_async_initgroups.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/providers/ldap/sdap_async_initgroups.c b/src/providers/ldap/sdap_async_initgroups.c
index be4384e23c7055a160d7f3e68c682b2843f65fdd..a1c73f96040859db10a0a89a4e1746119fa6d514 100644
--- a/src/providers/ldap/sdap_async_initgroups.c
+++ b/src/providers/ldap/sdap_async_initgroups.c
@@ -2128,6 +2128,8 @@ struct tevent_req *rfc2307bis_nested_groups_send(
}
}
+ ret = EOK;
+
done:
if (ret == EOK) {
/* All parent groups were already processed */
--
1.7.6.5
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
