On Wed, 2012-10-31 at 13:18 -0400, Stephen Gallagher wrote:
>  fail:
> -    DEBUG(2, ("Failed to save group [%s]\n",
> -              name ? name : "Unknown"));
> +    DEBUG(SSSDBG_MINOR_FAILURE,
> +          ("Failed to save group [%s]: [%s]\n",
> +           name ? name : "Unknown",
> +           strerror(ret))); 

Given you already print the strerror() in all previous debug messages,
does it make sense to repeat it here ?

(Otherwise ACK, patch looks good)

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to