On Mon, Nov 05, 2012 at 12:51:57PM +0100, Michal Židek wrote:
> On 11/01/2012 12:09 PM, Jakub Hrozek wrote:
> >On Thu, Oct 25, 2012 at 06:53:47PM +0200, Michal Židek wrote:
> >>I found this bug while working on:
> >>https://fedorahosted.org/sssd/ticket/1584
> >>
> >>If no objects for deletion were found in the currently searched
> >>sysdb database, the other sysdb databases were not searched at all.
> >>
> >>Also the ERROR message informing about specific object not found was
> >>changed to DEBUG message. It was really annoying seeing this message
> >>for all domains, but it can be useful for debugging (it helped me by
> >>testing this patch). Now only one ERROR message is printed if no
> >>matching objects where found and all domains were searched.
> >>
> >>Patch is attached.
> >>
> >>Thanks
> >>Michal
> >
> >This patch works as advertised.
> >
> >However, the per-domain per-type ERROR messages are now superseded by a 
> >generic
> >ERROR message when no objects match in any domain. I'm thinking we might
> >want to keep the per-domain ERROR message and at least include the
> >domain index number (...user not found in domain 1/2..) or even the
> >domain name.
> >
> >You can obtain it via sss_domain_info structure that can be returned
> >using sysdb_ctx_get_domain.
> 
> I did it as you suggested. The output looks good with the domain name.
> 
> New patch is attached.
> 
> Thanks
> Michal
> 

Pushed to master and sssd-1-9
_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to