On Tue, 2012-11-06 at 09:09 +0100, Jakub Hrozek wrote: > On Wed, Oct 31, 2012 at 06:37:33PM -0400, Simo Sorce wrote: > > Also do not intermix two tevent_req sequences > > --- > > src/providers/ipa/ipa_id.c | 151 > > +++++++++++++++++++++----------------------- > > 1 files changed, 71 insertions(+), 80 deletions(-) > > > > The code seems fine to me but can you just note in the commit message that > ipa_account_info_netgroups_done() is going to be removed/renamed in the > next commit? I first read the diff and then when I wanted to check the > whole code I couldn't find the function :)
Well the function 'just' moves around in this commit, I am not sure it makes much sense to highlight especially the destiny of this function, a lot of functions get renamed in the next patch. I will add more meat to the comment of the next patch to highlight functions get renamed. Simo. -- Simo Sorce * Red Hat, Inc * New York _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
