On Wed, 2012-11-14 at 15:18 +0100, Jan Cholasta wrote: > > Just one more nitpick: SSS_DB_CHECK_PTS and sss_db_version_check are > used only in sysdb.c, so there is no reason to have them defined > publicly in util.h+util.c. Move them both to sysdb.c please (you > might > also want to rename them to better fit in sysdb.c). >
Yes please, rename them to be sysdb_* functions and move them in sysdb where they belong. The util/ shouldn't have component specific functions. Simo. -- Simo Sorce * Red Hat, Inc * New York _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel