On Thu, Nov 29, 2012 at 01:36:42PM +0100, Jakub Hrozek wrote:
> On Thu, Nov 15, 2012 at 05:54:26PM +0100, Pavel Březina wrote:
> > >Nitpicking, but for this kind of situations I think a switch/case
> > >statement would be much more clear (also avoids adding a variable as you
> > >use it once):
> > >
> > >switch(cli_ctx->cli_protocol_version->version) {
> > >case 0:
> > >     DEBUG(..);
> > >     break;
> > >case SSS_SUDO_PROTOCOL_VERSION:
> > >     break;
> > >default:
> > >     DEBUG("invalid"...);
> > >     break;
> > >}
> > >
> > >Simo.
> > >
> > 
> > OK. New patch is attached.
> > 
> 
> Ack

Pushed to master.
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to