On 12/11/2012 03:58 PM, Jakub Hrozek wrote:
On Tue, Dec 11, 2012 at 03:53:25PM +0100, Jakub Hrozek wrote:
On Mon, Dec 10, 2012 at 12:35:29PM +0100, Pavel Březina wrote:
https://fedorahosted.org/sssd/ticket/1699

 From 246cf7edc92ed2826cf8295787cfb4e78d28ffd4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <[email protected]>
Date: Mon, 10 Dec 2012 12:23:25 +0100
Subject: [PATCH] let ldap_chpass_uri failover work when using same hostname

https://fedorahosted.org/sssd/ticket/1699

We want to continue with the next server on all errors, not only
on ETIMEDOUT.


I'm not quite sure, I think the intent was to only retry on
network-related errors and fail right away with fatal errors like
ENOMEM.

I followed the code in sdap_cli_connect_done(), which uses the same connection API. We don't differentiate between errors there.

This particullar ticket was dealing with ECONNREFUSED.

Can you check where the ECONNREFUSED error came from? Maybe we're just
missing another special case for lret like the ones at the end of
sdap_sys_connect_done().

Also what about the same condition in auth_bind_user_done() ?

One more question -- the QE have identified this problem as a regression
since 1.8.x The code you changed predates 1.8, I think...so while it
might be fixing the symptoms, it probably is not the place that
regressed.
_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to