On 01/19/2013 03:28 PM, Jakub Hrozek wrote:
On Fri, Jan 18, 2013 at 01:56:02PM +0100, Pavel Březina wrote:
On 01/18/2013 11:25 AM, Jakub Hrozek wrote:
On Fri, Jan 18, 2013 at 10:47:34AM +0100, Pavel Březina wrote:
On 01/16/2013 03:20 PM, Jakub Hrozek wrote:
This patch applies on top of sssd-1-9
https://fedorahosted.org/sssd/ticket/1758
The autofs entries do not have the key as an unique identifier, but
rather the full (key, value) tuple as some keys have a special meaning,
such as the direct mount key (/-) and may be present in a single map
multiple times.
Comparing the full DN that contains both the key and the value will
allow for working updates if either key or value changes.
Hi,
the patch does not apply to current master.
See original mail:
"This patch applies on top of sssd-1-9"
Originally I was trying to meet a deadline so I went with 1.9 first. But
you're right we need to fix the same problem in master, too. I will
prepare a version for master.
Ah, my bad.
Nack.
get_autofs_entry_attr(): we should also check if el->num_values > 1 and
error out if it happens.
Well, I think it's better to try to carry, but the new patch simply
errors out if num_values != 1.
del_autofs_entries(): please, remove the FIXME :-) If you want to wrap
it in sysdb function, it can be done in a minute. If you don't I don't
mind in this case.
OK, I moved the code into sysdb where it logically belongs.
sdap_autofs_setautomntent_save(): you don't use same_entries anywhere
Thanks, I was using it during debugging to see if the diff returns the
expected results and forgot to remove it.
Thank you for the review, a new patch is attached. I also sent a patch
that applies on master with these comments factored in.
Ack.
_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
