On 22/01/13 14:48, Jakub Hrozek wrote:
On Tue, Jan 22, 2013 at 01:56:45PM +0100, Ondrej Kos wrote:
+ ret = sysdb_transaction_commit(test_ctx->sysdb);
+ fail_if(ret != EOK);
+
+ ret = sysdb_transaction_start(test_ctx->sysdb);
+ fail_if(ret != EOK);
Can you also add an error message?
_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
New patch attached, also in second patch, i added the error messages to
other tests, where it was missing.
Ondra
--
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech
phone: +420-532-294-558
cell: +420-736-417-909
ext: 82-62558
loc: 1013 Brno 1 office
irc: okos @ #brno
From 0100bb2b3196cdd6d435dceb6e6cf09bd17fdeba Mon Sep 17 00:00:00 2001
From: Ondrej Kos <[email protected]>
Date: Tue, 22 Jan 2013 13:55:09 +0100
Subject: [PATCH 1/2] TESTS: Fix coverity issues 13126, 13127
https://fedorahosted.org/sssd/ticket/1763
---
src/tests/sysdb-tests.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/tests/sysdb-tests.c b/src/tests/sysdb-tests.c
index 0b042cbd807fc43b6a9f874174c182553ab668b0..f0cf8d8710b0c0d73ae2961b3038275fec4cf7a7 100644
--- a/src/tests/sysdb-tests.c
+++ b/src/tests/sysdb-tests.c
@@ -4363,8 +4363,12 @@ START_TEST(test_sysdb_svc_remove_alias)
ret = sysdb_svc_remove_alias(test_ctx->sysdb, dn, aliases[1]);
fail_if (ret != EOK, "[%s]", strerror(ret));
- sysdb_transaction_commit(test_ctx->sysdb);
- sysdb_transaction_start(test_ctx->sysdb);
+
+ ret = sysdb_transaction_commit(test_ctx->sysdb);
+ fail_if(ret != EOK, "[%s]", strerror(ret));
+
+ ret = sysdb_transaction_start(test_ctx->sysdb);
+ fail_if(ret != EOK, "[%s]", strerror(ret));
/* Set aliases[1] to NULL to perform validation checks */
aliases[1] = NULL;
--
1.7.11.7
From 8c0806f90d49f84d244b279fc87e66d155e47ae3 Mon Sep 17 00:00:00 2001
From: Ondrej Kos <[email protected]>
Date: Tue, 22 Jan 2013 15:10:31 +0100
Subject: [PATCH 2/2] TESTS: include error message on fail
---
src/tests/sysdb-tests.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/tests/sysdb-tests.c b/src/tests/sysdb-tests.c
index f0cf8d8710b0c0d73ae2961b3038275fec4cf7a7..862779a2bf4edcf7a96100fb59ae7b14325fd4f6 100644
--- a/src/tests/sysdb-tests.c
+++ b/src/tests/sysdb-tests.c
@@ -4145,7 +4145,7 @@ START_TEST(test_sysdb_add_services)
protocols[2] = NULL;
ret = sysdb_transaction_start(test_ctx->sysdb);
- fail_if(ret != EOK);
+ fail_if(ret != EOK, "[%s]", strerror(ret));
ret = sysdb_svc_add(NULL, test_ctx->sysdb, test_ctx->domain,
primary_name, port,
@@ -4164,7 +4164,7 @@ START_TEST(test_sysdb_add_services)
aliases, protocols);
ret = sysdb_transaction_commit(test_ctx->sysdb);
- fail_if (ret != EOK);
+ fail_if(ret != EOK, "[%s]", strerror(ret));
/* Clean up after ourselves (and test deleting by name)
*
@@ -4174,7 +4174,7 @@ START_TEST(test_sysdb_add_services)
*/
ret = sysdb_svc_delete(test_ctx->sysdb, test_ctx->domain,
primary_name, 0, NULL);
- fail_if(ret != EOK);
+ fail_if(ret != EOK, "[%s]", strerror(ret));
talloc_free(test_ctx);
}
@@ -4218,14 +4218,14 @@ START_TEST(test_sysdb_store_services)
protocols[2] = NULL;
ret = sysdb_transaction_start(test_ctx->sysdb);
- fail_if(ret != EOK);
+ fail_if(ret != EOK, "[%s]", strerror(ret));
/* Store this group (which will add it) */
ret = sysdb_store_service(test_ctx->sysdb, test_ctx->domain,
primary_name, port,
aliases, protocols,
NULL, NULL, 1, 1);
- fail_if (ret != EOK);
+ fail_if(ret != EOK, "[%s]", strerror(ret));
/* Search by name and make sure the results match */
services_check_match_name(test_ctx,
@@ -4291,7 +4291,7 @@ START_TEST(test_sysdb_store_services)
*/
ret = sysdb_svc_delete(test_ctx->sysdb, test_ctx->domain,
NULL, altport, NULL);
- fail_if(ret != EOK);
+ fail_if(ret != EOK, "[%s]", strerror(ret));
talloc_free(test_ctx);
}
@@ -4339,7 +4339,7 @@ START_TEST(test_sysdb_svc_remove_alias)
protocols[2] = NULL;
ret = sysdb_transaction_start(test_ctx->sysdb);
- fail_if(ret != EOK);
+ fail_if(ret != EOK, "[%s]", strerror(ret));
ret = sysdb_svc_add(NULL, test_ctx->sysdb, test_ctx->domain,
primary_name, port,
@@ -4384,7 +4384,7 @@ START_TEST(test_sysdb_svc_remove_alias)
aliases, protocols);
ret = sysdb_transaction_commit(test_ctx->sysdb);
- fail_if(ret != EOK);
+ fail_if(ret != EOK, "[%s]", strerror(ret));
talloc_free(test_ctx);
}
--
1.7.11.7
_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
