On 23/12/12 20:18, Dmitri Pal wrote:
Patch 1 https://fedorahosted.org/sssd/ticket/766
Patch 2 https://fedorahosted.org/sssd/ticket/1276
Patch 3 https://fedorahosted.org/sssd/ticket/1246
Patch 4 https://fedorahosted.org/sssd/ticket/1532
[PATCH 1/4]
just a nitpick,
+enum ERR_LEVEL {
+ INI_STOP_ON_ANY = 0, /**< Fail if any problem is detected. */
+ INI_STOP_ON_NONE = 1, /**< Best effort - do not fail. */
+ INI_STOP_ON_ERROR = 2 /**< Fail on errors only. */
+};
while using enum, it's unnecessary to enter values like this, when the
variables are in row
[PATCH 2/4]
Ack
[PATCH 3/4]
Ack
[PATCH 4/4]
trailing whitespace errors
On 23/12/12 20:18, Dmitri Pal wrote:
Applying: Replacing sprintf with sprintf
/home/okos/devel/ding-libs/.git/rebase-apply/patch:22: trailing whitespace.
/home/okos/devel/ding-libs/.git/rebase-apply/patch:203: trailing whitespace.
printf("This is unexpected error %d in mode %d\n",
warning: 2 lines add whitespace errors.
Also, the patch name says "Replacing sprintf with sprintf", shouldn't it
be "Replacing sprintf with snprintf" ?
Otherwise, it's an Ack
Ondra
--
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech
phone: +420-532-294-558
cell: +420-736-417-909
ext: 82-62558
loc: 1013 Brno 1 office
irc: okos @ #brno
_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
