On 01/25/2013 04:12 PM, Michal Židek wrote:
Bug found by coverity.
https://fedorahosted.org/sssd/ticket/1790
Patch is attached.
Thanks
Michal
_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
This is the correct patch. I forgot to rebase -i and fixup one change in
the previous one, so it did not compile.
Thanks
Michal
>From 25c86771bdc501e4f277e7b36c4add225eda8a15 Mon Sep 17 00:00:00 2001
From: Michal Zidek <[email protected]>
Date: Fri, 25 Jan 2013 15:49:29 +0100
Subject: [PATCH] Possible null derefence in ipa_subdomains.c.
Found by coverity.
https://fedorahosted.org/sssd/ticket/1790
---
src/providers/ipa/ipa_subdomains.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/providers/ipa/ipa_subdomains.c b/src/providers/ipa/ipa_subdomains.c
index c9ab3aa..c435e12 100644
--- a/src/providers/ipa/ipa_subdomains.c
+++ b/src/providers/ipa/ipa_subdomains.c
@@ -930,6 +930,10 @@ static void ipa_subdom_online_cb(void *pvt)
be_req = be_req_create(ctx, NULL, ctx->be_ctx,
ipa_subdom_be_req_callback, NULL);
+ if (be_req == NULL) {
+ DEBUG(SSSDBG_CRIT_FAILURE, ("talloc_zero() failed.\n"));
+ return;
+ }
ipa_subdomains_retrieve(ctx, be_req);
--
1.7.11.2
_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
