-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

We were not properly detecting that cmocka was unavailable. It was
expecting an empty value and getting "no" instead. This patch
corrects the expectation, so we will now skip building and running
cmocka tests on platforms that do not have it available.

Also, the common_cmocka.h header was missing from the distribution
tarball, causing 'make distcheck' to fail.





Note: the nss cmocka test is consistently segfaulting for me during
'make distcheck' on F18 x86_64. I haven't had time to look into why,
yet. It works fine in normal 'make check', so I suspect there's likely
something going on with permissions (since 'make check' sets $libdir
as read-only). But that's just a guess.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlE+CIYACgkQeiVVYja6o6O66ACgkhgxp6LcyPGrAPcn/mmc6ZlE
APgAoJqIq8MJAggW0K8mYpuFTNsiL7Hn
=CEvx
-----END PGP SIGNATURE-----
>From e87fe6df8f754aa0c40243f53f831d0337ef7304 Mon Sep 17 00:00:00 2001
From: Stephen Gallagher <sgall...@redhat.com>
Date: Mon, 11 Mar 2013 12:28:23 -0400
Subject: [PATCH] BUILD: Fix cmocka

We were not properly detecting that cmocka was unavailable. It was
expecting an empty value and getting "no" instead. This patch
corrects the expectation, so we will now skip building and running
cmocka tests on platforms that do not have it available.

Also, the common_cmocka.h header was missing from the distribution
tarball, causing 'make distcheck' to fail.

---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 0e7712389d99cf1b903ae1dbf063d889be62d7b0..4b1cfba26166bbe407ce219d8ad86e8b1a94c88b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -270,7 +270,7 @@ AC_PATH_PROG([DOXYGEN], [doxygen], [false])
 AM_CONDITIONAL([HAVE_DOXYGEN], [test x$DOXYGEN != xfalse ])
 
 AM_CONDITIONAL([HAVE_CHECK], [test x$have_check != x])
-AM_CONDITIONAL([HAVE_CMOCKA], [test x$have_cmocka != x])
+AM_CONDITIONAL([HAVE_CMOCKA], [test x$have_cmocka = xyes])
 
 abs_build_dir=`pwd`
 AC_DEFINE_UNQUOTED([ABS_BUILD_DIR], ["$abs_build_dir"], [Absolute path to the build directory])
-- 
1.8.1.4

Attachment: 0001-BUILD-Fix-cmocka-detection.patch.sig
Description: PGP signature

_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to