On Thu, Mar 28, 2013 at 03:59:25PM +0100, Ondrej Kos wrote: > Hi, > > Attached is patch for https://fedorahosted.org/sssd/ticket/1786 > > Patch extends sssd code so it's capable to build with current > version of libini_config (0.7 at the time, supported versions up > from 0.6.1) and with version 1.0.0, which will be released soon. >
I can use this patch as an interim solution in rawhide and F19 until we ack it but it needs some work. Mainly, please don't use ifdefs in general code. ifdefs should be used in a wrapper module to provide kind of generic methods the user would then call but ifdefs in main code obfuscate it. See src/util/sss_krb5.c or src/util/sss_ldap.c for examples. We should amend our coding guidelines to specifically advise to put ifdefs into a wrapper module. I know that there is the netlink module which does the same but arguably the netlink module is a wrapper module mostly and actually we might want to split it in future (feel free to file a ticket). So there should be a src/util/sss_col.c module or something like that that would export functions or macros with the same prototype no matter the libini version. That module will contain a function that will return ldif which can be then consumed by confdb. Also please don't use the old debug levels in new code. _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
