Hi,

this patch fixes a compiler warning in the latest master.

bye,
Sumit
From c34378b20536504cadf0a7df0a6aa5aa1ec82304 Mon Sep 17 00:00:00 2001
From: Sumit Bose <[email protected]>
Date: Fri, 23 Aug 2013 10:13:02 +0200
Subject: [PATCH] check_cc_validity: make sure _valid is always set

In the KRB5_FCC_NOFILE code path _valid is not set leading to 'may be
used uninitialized' compiler warnings.
---
 src/providers/krb5/krb5_utils.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/providers/krb5/krb5_utils.c b/src/providers/krb5/krb5_utils.c
index 13ba9b5..a96fd55 100644
--- a/src/providers/krb5/krb5_utils.c
+++ b/src/providers/krb5/krb5_utils.c
@@ -750,12 +750,12 @@ check_cc_validity(const char *location,
     }
 
     ret = EOK;
-    *_valid = valid;
 
- done:
-     if (ccache) krb5_cc_close(context, ccache);
-     krb5_free_context(context);
-     return ret;
+done:
+    *_valid = valid;
+    if (ccache) krb5_cc_close(context, ccache);
+    krb5_free_context(context);
+    return ret;
 }
 
 /*======== ccache back end utilities ========*/
-- 
1.7.7.6

_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to