On Wed, Aug 28, 2013 at 04:39:00PM +0200, Jakub Hrozek wrote:
> On Wed, Aug 28, 2013 at 04:35:14PM +0200, Michal Židek wrote:
> > Just a small typo... i think this can be amended before
> > pushing.
> > 
> > On 08/20/2013 10:32 AM, Lukas Slebodnik wrote:
> > >-    if (hash > mcc->ht_size) {
> > >-        /* Invalid hash. This should never happen, but better
> > >-         * return than trying to access out of bounds memory */
> > >+    if (hash > MC_HT_ELEMS(mcc->ht_size)) {
> > >+        /* It can happen if rec->hash1 and rec->has2 was the same.
> >                                                    ^^^^ s/has2/hash2
> > >+         * or it is invalid hash. It is better to return
> > >+         * than trying to access out of bounds memory
> > >+         */
> > >          return;
> > >      }
> > 
> > But he code itself is OK.
> > 
> > Michal
> 
> Thanks for the second look, I tested the code and memcache works OK for
> me, but the memcache is one area of SSSD I don't really know well.

Fixed the comment and pushed the patches to master, sssd-1-10, sssd-1-9
_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to