On 09/03/2013 01:27 PM, Sumit Bose wrote:
Hi,while looking at expand_ccname_template() becasue of shadowing rewind() I realized that there a some issues with some of the new krb5.conf templates. This patch fixes them and adds some tests to avoid similar issues in the future. There is one change in behaviour. If the name in the %{} braces does not match any of the known krb5.conf templates for UNIX the new code returns an error while the old just returned something, which in most case will not be the original input. Please tell me if you prefer the original input in this case so that I can change the patch accordingly.
I think we should expand the parameters we can, i.e. uid and euid and leave everything else intact (i.e. don't even check ${LIBDIR} etc.). Ad absurdum: for what we know, users can ran custom build that supports other variables...
But if you don't agree, I'll ack this patch.
bye, Sumit
_______________________________________________ sssd-devel mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
