On (22/07/13 11:43), Jakub Hrozek wrote:
>On Fri, Jul 19, 2013 at 03:36:22PM +0200, Lukas Slebodnik wrote:
>> On (19/07/13 10:29), Jakub Hrozek wrote:
>> >On Thu, Jul 18, 2013 at 01:09:11PM +0200, Lukas Slebodnik wrote:
>> >> ehlo,
>> >>
>> >> I tested some patches with old distro and I spotted warnings.
>> >> -- uninitialized variable (gcc 4.4.7)
>> >> -- macro AM_PROG_AR not found in library (automake 1.11.1)
>> >>
>> >> I checked them and all warnings should be harmless, but anyway we don't
>> >> like
>> >> warnings.
>> >>
>> >> Two patches are attached.
>> >>
>> >> LS
>> >
>> >Patch #1 really needs to be split into two, the Makefile.am/sssd.spec.in
>> >is a separate issue.
>> I removed changes to files Makefile.am/sssd.spec.in.
>> (I use those changes only internally.)
>>
>> >
>> >Patch #2 looks OK to me, is the automake version you tested with (1.11.1)
>> >the one shipped on RHEL5?
>> RHEL6, master can not be built on RHEL5.
>>
>> Updated patches are attached
>>
>> LS
>
>[PATCH 1/2] Fix warnings: uninitialized variable
>Ack after all. I checked all the functions you touched and I think GCC
>is simply wrong. However, setting the variables is OK and doesn't change
>the flow in any way.
>
>[PATCH 2/2] Fix autotols warnings: macro xyz not found in library
>Ack, builds fine on Fedora and RHEL6.
I tested Michal's patch "[PATCH] Check slot validity before MC_SLOT_TO_PTR"
on 1-9 branch and there are a lot of automake warnings on fedora 19.
/usr/share/automake-1.13/am/ltlibrary.am:
archiver requires 'AM_PROG_AR' in 'configure.ac'
The 2nd patch is attached for sssd-1-9 branch.
LS
>From a18a2f9f18b264d1028b6d92c1746a24a2ba49a7 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <[email protected]>
Date: Mon, 16 Sep 2013 10:19:31 +0200
Subject: [PATCH] AUTOTOOLS: Fix warnings: macro xyz not found in library
This patch also fixes warning generated by newer version of automake.
/usr/share/automake-1.13/am/ltlibrary.am:
archiver requires 'AM_PROG_AR' in 'configure.ac'
---
configure.ac | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index
cc25be511d0dbe9bf485bebda4ac2c19a271abd8..7969f58120348a806ae6f05db8696a5a70bb3b27
100644
--- a/configure.ac
+++ b/configure.ac
@@ -16,6 +16,7 @@ AC_CONFIG_AUX_DIR([build])
AM_INIT_AUTOMAKE([-Wall foreign subdir-objects tar-pax])
AM_PROG_CC_C_O
+m4_ifdef([AM_PROG_AR], [AM_PROG_AR])
AC_DISABLE_STATIC
AC_PROG_INSTALL
AC_PROG_LIBTOOL
@@ -32,8 +33,7 @@ AC_DEFINE([PRERELEASE_VERSION], "PRERELEASE_VERSION_NUMBER",
AM_CONDITIONAL([GIT_CHECKOUT], [git log -1 >/dev/null 2>&1])
-m4_pattern_allow([AM_SILENT_RULES])
-AM_SILENT_RULES
+m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES])
AM_CONDITIONAL([HAVE_GCC], [test "$ac_cv_prog_gcc" = yes])
--
1.8.3.1
_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
