On Tue, Oct 15, 2013 at 10:38:51AM +0200, Lukas Slebodnik wrote:
> On (15/10/13 10:30), Sumit Bose wrote:
> >On Mon, Oct 14, 2013 at 05:51:40PM +0200, Lukas Slebodnik wrote:
> >> On (14/10/13 16:48), Sumit Bose wrote:
> >> >On Mon, Oct 14, 2013 at 01:37:01PM +0200, Sumit Bose wrote:
> >> >> On Mon, Oct 14, 2013 at 01:15:02PM +0200, Benjamin Franzke wrote:
> >> >> > Hi Sumit,
> >> >> > 
> >> >> > Should the spec file also include an /etc/alternatives integration, 
> >> >> > like
> >> >> > cifs-utils has?
> >> >> > http://pkgs.fedoraproject.org/cgit/cifs-utils.git/tree/cifs-utils.spec#n90
> >> >> 
> >> >> yes, my plan was to include this into the spec file for the Fedora
> >> >> package. I thought for the upstream spec file this is not needed since
> >> >> cifs-utils upstream does not use it either.
> >> >> 
> >> >> On the other hand I guess the upstream spec file will be used mostly by
> >> >> Fedora/RHEL users to replace the distributed SSSD packages. So it makes
> >> >> sense to include it upstream as well. I'll send a new patch.
> >> >
> >> >Please find attached a new version with alternatives.
> >> >
> >> >bye,
> >> >Sumit
> >> >
> >> >> 
> >> >> bye,
> >> >> Sumit
> >> >> 
> >> >> > 
> >> >> > 
> >> >> > 2013/10/14 Sumit Bose <[email protected]>
> >> >> > 
> >> >> > > and now with the patch included :-)
> >> >> > >
> >> >> > > On Mon, Oct 14, 2013 at 01:08:39PM +0200, Sumit Bose wrote:
> >> >> > > > Hi,
> >> >> > > >
> >> >> > > > as promised I created the spec file changes to include the 
> >> >> > > > cifs-utils
> >> >> > > > plugin into the sssd-client package on Fedora and RHEL platforms 
> >> >> > > > where
> >> >> > > > recent cifs-utils are available.
> >> >> > > >
> >> >> > > > bye,
> >> >> > > > Sumit
> >> >> > >
> >> >> > > _______________________________________________
> >> >> > > sssd-devel mailing list
> >> >> > > [email protected]
> >> >> > > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> >> >> > >
> >> >> > >
> >> 
> >> I tested patch together with patch "Add CIFS idmap plugin" with small 
> >> change.
> >> -if [ $1 = 0 ]; then
> >> +if [ $1 -eq 0 ]; then
> >> 
> >> mock build for fedora 19 -- OK
> >> mock build for RHEL6 -- OK
> >> 
> >> Alternative was updated after install
> >> -------------------------------------
> >> bash# yum install sssd-client
> >>   ... snip ...
> >> bash# update-alternatives --display cifs-idmap-plugin
> >> cifs-idmap-plugin - status is auto.
> >>   link currently points to /usr/lib64/cifs-utils/cifs_idmap_sss.so
> >> /usr/lib64/cifs-utils/idmapwb.so - priority 10
> >> /usr/lib64/cifs-utils/cifs_idmap_sss.so - priority 20
> >> Current `best' version is /usr/lib64/cifs-utils/cifs_idmap_sss.so.
> >>
> >> Alternative was removed after remove
> >> ------------------------------------
> >> bash# yum remove sssd-client
> >>   ... snip ...
> >> bash# update-alternatives --display cifs-idmap-plugin
> >> cifs-idmap-plugin - status is auto.
> >>  link currently points to /usr/lib64/cifs-utils/idmapwb.so
> >> /usr/lib64/cifs-utils/idmapwb.so - priority 10
> >> Current `best' version is /usr/lib64/cifs-utils/idmapwb.so.
> >
> >Thanks for testing. New version with -eq attached.
> >
> >bye,
> >Sumit
> >
> >>
> >> LS
> 
> ACK

thanks.

Pushed to master.

bye,
Sumit
> 
> LS
> _______________________________________________
> sssd-devel mailing list
> [email protected]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to