-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11/09/2013 08:59 AM, Pallavi Jha wrote: > Hi > > I have created the patch and attached it with this mail. Kindly > review it. I have commented some of the test as it fails(gives > segmentation fault) when authtoken is NULL. I think we should test > tok for NULL before accessing its elements. Please correct me if am > wrong. > > for example : > > uint8_t *sss_authtok_get_data(struct sss_auth_token *tok) { return > tok->data; } > > This should be written as: > > uint8_t *sss_authtok_get_data(struct sss_auth_token *tok) { > if(!tok) { return EINVAL; } return tok->data; } > > Thanking You, Pallavi
I think you may have forgotten to attach the patch, Pallavi. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlKA3kwACgkQeiVVYja6o6ONTwCgheuQ1ZLfNN79nSFR9O64R8Qo L54An12Fp14jEThaNW2EM1OJxtBdbpta =mdMQ -----END PGP SIGNATURE----- _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel