-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01/13/2014 06:00 AM, Lukas Slebodnik wrote: > ehlo, > > Attached patches fix warnings with compiler flag > Wmissing-prototypes. In my opinion, it is better declare function > with static modifier if function is not part of public API. >
Patch 0001: Ack This will necessitate an soname bump (in case you were unaware). Even though they were not specified in the header, these symbols would have been exported. That means you will need to adjust the version-info accordingly. > patch 0002-Use-static-modifier-for-unit-test-functions.patch helps > me find out that negative_test was not execupted as part of INI > unit tests. > Patch 0002: Ack Patch 0003: Ack > 0004-REFARRAY-Move-declaration-of-ref_array_debug-to-priv.patch It > is better to have declaration in private header file, beacuse it > prevents copy&paste errors. Declaration in file > ini/ini_valueobj_ut.c was wrong. > Patch 0004: Ack > The last patch enables extra compiler warnings including > Wmissing-prototypes. > Patch 0005: Ack > LS > > > > _______________________________________________ sssd-devel mailing > list sssd-devel@lists.fedorahosted.org > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlLUPPcACgkQeiVVYja6o6MsvgCfcizq3W2jAxtrM7HixbGo8JqD TnkAoIj3EJgVQBYiD2IoMBxksodVfL/m =lWcc -----END PGP SIGNATURE----- _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
