On Mon, Jan 20, 2014 at 06:21:43PM +0100, Lukas Slebodnik wrote: > >> >So would you like strerror (or rather sss_strerror) to be used? > >> > > >> In this case sss_strerror due to ERR_DOMAIN_NOT_FOUND > > > >Right, done. > > > >> > >> >> > >> >> Does SSSDBG_MINOR_FAILURE need to be used? We can recover without any > >> >> problem. > >> >> In my opinion, it would be better to use different level. > >> >> > >> > > >> >I don't have a strong opinion on this, I used MINOR_FAILURE because > >> >well, it's a recoverable failure :-) > >> > >> I don't have a strong opinion about this :-) > > > >I used a higher level because I remembered that in Kaushik's case the > >user in question was a legitimate local user like nobody of nfsnobody. > > >From 05ce4ed7c8adbfac755d323902c5678f445bd7be Mon Sep 17 00:00:00 2001 > >From: Jakub Hrozek <jhro...@redhat.com> > >Date: Thu, 16 Jan 2014 20:49:15 +0100 > >Subject: [PATCH] AD: Don't fail the request if ad_account_can_shortcut fails > > > > ACK > > LS
Thanks for the review, pushed to master and sssd-1-11 _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
