On (08/03/14 02:00), Dmitri Pal wrote: >On 03/08/2014 01:40 AM, Dmitri Pal wrote: >>On 03/07/2014 12:00 PM, Jakub Hrozek wrote: >>>On Fri, Mar 07, 2014 at 05:49:44PM +0100, Jakub Hrozek wrote: >>>>On Fri, Mar 07, 2014 at 10:19:11AM -0500, Dmitri Pal wrote: >>>>>On 03/07/2014 10:11 AM, Jan Engelhardt wrote: >>>>>>On Friday 2014-03-07 15:15, Lukas Slebodnik wrote: >>>>>>>>>>>>attached patch addresses ticket #2193 >>>>>>>Jan, >>>>>>>Do you have any other comments to the patch from previous mail? >>>>>>No further comments at this time. Please, just get it >>>>>>included already :} >>>>>>_______________________________________________ >>>>>>sssd-devel mailing list >>>>>>sssd-devel@lists.fedorahosted.org >>>>>>https://lists.fedorahosted.org/mailman/listinfo/sssd-devel >>>>>I am preparing a new patch for ini and it will add two new entry >>>>>points but I can't finish the work until your patch is pushed. >>>>ACK from me. make, make check, make distcheck and make rpms work fine. >>>> >>>>SSSD also seems to be working fine after I upgraded ding-libs >>>>to the new >>>>RPMs. >>>Pushed to ding-libs master. >>>_______________________________________________ >>>sssd-devel mailing list >>>sssd-devel@lists.fedorahosted.org >>>https://lists.fedorahosted.org/mailman/listinfo/sssd-devel >> >> >>This push broke my deb builds on RHEL6: > >s/deb/dev > >Also removing EXTRA_ prefix seems to fix the issue. >> >>[dpal@dpal ding-libs (master)]$ autoreconf -if >>libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, `build'. >>libtoolize: copying file `build/ltmain.sh' >>libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'. >>libtoolize: copying file `m4/libtool.m4' >>libtoolize: copying file `m4/ltoptions.m4' >>libtoolize: copying file `m4/ltsugar.m4' >>libtoolize: copying file `m4/ltversion.m4' >>libtoolize: copying file `m4/lt~obsolete.m4' >>Makefile.am:259: variable `EXTRA_libini_config_la_DEPENDENCIES' is >>defined but no program or >>Makefile.am:259: library has `EXTRA_libini_config_la' as canonical >>name (possible typo) >>autoreconf: automake failed with exit status: 1 >> >> >
The EXTRA_*_DEPENDENCIES variable is useful for cases where you merely want to augment the automake-generated _DEPENDENCIES variable rather than replacing it. http://www.gnu.org/software/automake/manual/html_node/Program-and-Library-Variables.html It is a syntax warning in automake < 1.11.3 and syntax warnings are enabled by default. http://lists.gnu.org/archive/html/automake-patches/2010-10/msg00008.html Makefile.am:259: variable `EXTRA_libini_config_la_DEPENDENCIES' is defined but no program or library has `EXTRA_libini_config_la' as canonical name (possible typo) autoreconf: automake failed with exit status: 1 It would be better don't treat warnings as errors in automake. The only negative of this solution is that library libini_conf will not be recompiled with older version of automake if files listed in EXTRA_*_DEPENDENCIES are changed. It is better to see warnings than override automatically generated dependencies calculated by automake with syntax: *_DEPENDENCIES Patch is attached. LS _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
