On Wed, Mar 12, 2014 at 10:44:12PM +0100, Jakub Hrozek wrote: > On Mon, Mar 10, 2014 at 07:50:04AM +0100, Lukas Slebodnik wrote: > > ehlo, > > > > Few comments to some patches. > > > > 0001-TEST-Remove-unused-argument-sysdb_path.patch > > Name of sysdb file is automatically generated from domain name and db_path > > in function sysdb_domain_init. > > ACK > > > > > 0002-TEST-Use-right-domain-name-in-negcache-test.patch > > > > Directory tests_ncache was not removed after negcache test, > > because sysdb cache had different name and was not removed in the function > > test_dom_suite_cleanup. > > > > [sssd] [test_dom_suite_cleanup] (0x0020): > > Could not delete the test dir (39) (Directory not empty) > > ACK > > 0003: ACK > I would have expected the cleanup to be parametrized as with other > tests, but this works as well. > > > > > 0004-hbac-test-Use-defined-macros-instead-of-strings.patch > > > > Macro HBAC_TEST_SRCHOSTGROUP2 was defined but it was not used anywhere. > > ACK > > > > > LS > > 0005: ACK
All patches were pushed upstream. _______________________________________________ sssd-devel mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
