On Thu, Mar 20, 2014 at 10:08:20AM +0100, Lukas Slebodnik wrote: > On (19/03/14 19:35), Nikolai Kondrashov wrote: > >Hi Lukas, > > > >On 03/19/2014 04:21 PM, Lukas Slebodnik wrote: > >>On (19/03/14 14:59), Nikolai Kondrashov wrote: > >>>Remove support for "--with-distro-version" configure option as unused. > >>> > >>>The option was added in August 2011 (d3da1c1). As of now nothing seems > >>>to use it. Packaging checked: rpm, deb, pacman, ebuilds, FreeBSD ports. > >> > >>I know it is not used. but can be used in future. > >>For example: > >> --library for nsswitch on linux has name libnss_sss.so > >> --library for nsswitch on *BSD has name nss_sss.so > >>This is a potential use case. > > > >This option was intended to allow distribution packaging to add a suffix to > >the version reported by "sssd --version". I'm not sure how that helps to > >differentiate library names. I'd say something like "--with-nss" should be > >used instead. > > > I have always thought it is argument "--with-distro" and should be used for > distribution specific features/differences. (maybe I am blind) > > ACK
Unused code is broken code. I think if someone really uses this option they'd come back and shout. Pushed to master: d880cd72bf9ac203da973a56c4737b3ac05706a8 _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
