On (30/04/14 19:14), Nikolai Kondrashov wrote: >Hi everyone, > >Here is my backport of the DEBUG macro refactoring patchset to sssd-1-11 >branch. > >Patches are mostly identical to master, with the exception of the changes >generated by scripts (which were re-run), some commit messages and one commit >being moved into a more logical place in history. > >All patches that should work passed "make check" both on RHEL7 and Fedora 20 >(verified by CI). > >I've left the original Reviewed-by tags for the commits with unchanged >content, but I can remove them, if necessary. > >Sincerely, >Nick
I realised that sssd cannot be built after applying the 5th and the 6th patch. 0005-Make-DEBUG-macro-definition-variadic.patch 0006-Make-DEBUG-macro-invocations-variadic.patch It is fixed by the 7th patch. 0007-Fixup-DEBUG-macro-invocations-update.patch Now, it does not worth to modify patches, because the same problem is in master. I should have reviewed them. Just for the record. It is better to modify patches even if they are generated by script. It causes problem with bisecting. Sometimes problem can be solved easily. In my opinion, we should be able to compile each commit. Jakub, please push these patches to 1-11 very soon. We do not want to rebase them like patchset for master. ACK LS _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
