On Fri, May 02, 2014 at 12:30:29PM +0200, Pavel Březina wrote:
> On 04/30/2014 05:01 PM, Jakub Hrozek wrote:
> >On Wed, Apr 30, 2014 at 03:18:11PM +0200, Jan Pazdziora wrote:
> >>On Mon, Apr 28, 2014 at 10:20:08PM +0200, Jakub Hrozek wrote:
> >>>
> >>>can I get a final ACK (or a non-file NACK :-)) on the patches?
> >>
> >>Not sure if you are waiting on ack from me but I confirm that the
> >>.src.rpm you provided me with has the ldap_user_extra_attrs behaviour
> >>as documented, so I can have in [domain/*]
> >>
> >>    ldap_user_extra_attrs = email:mail, firstname:givenname, lastname:sn
> >>
> >>and in [ifp]
> >>
> >>    user_attributes = +email, +firstname, +lastname
> >>
> >>a retrieve attribute values from mod_lookup_identity using
> >>
> >>    LookupUserAttr email REMOTE_USER_EMAIL " "
> >>    LookupUserAttr firstname REMOTE_USER_FIRSTNAME
> >>    LookupUserAttr lastname REMOTE_USER_LASTNAME
> >
> >Awesome, thanks a lot for confirmation and testing!
> >
> >I would prefer to get a code-wise ACK from someone familiar with SSSD
> >code, though. Thanks to your testing, the reviewer can now only check
> >out the code.
> >
> 
> Ack.

Pushed to master:
     4dd38025efda88f123eac672f87d3cda12f050c8
     d2969c6b23c722445bd699c830adb7601ba1cdc6
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to