On Sun, May 25, 2014 at 09:52:26PM +0200, Pavel Březina wrote:
> On 05/23/2014 09:13 PM, Sumit Bose wrote:
> >On Fri, May 23, 2014 at 07:09:23PM +0200, Pavel Březina wrote:
> >>On 05/23/2014 07:06 PM, Sumit Bose wrote:
> >>>On Thu, May 22, 2014 at 09:00:49PM +0200, Pavel Březina wrote:
> >>>>On 05/22/2014 11:17 AM, Sumit Bose wrote:
> >>>>>On Thu, May 22, 2014 at 11:07:51AM +0200, Sumit Bose wrote:
> >>>>>>On Mon, May 19, 2014 at 10:40:40PM +0200, Pavel Březina wrote:
> >>>>>>>On 05/16/2014 03:32 PM, Jakub Hrozek wrote:
> >>>
> >>>
> >>>Maybe we can split the header file like libcurl does so that the caller can
> >>>decided if he prefers sss_sifp_easy.h where dbus includes file are not
> >>>required
> >>>or the more flexible sss_sifp.h ?
> >>
> >>Ok, we can do that. How about moving the functions that requires dbus
> >>headers into sss_sifp_dbus.h?
> >>
> >
> >I'm fine with the name. Do you have time to do this, or shall I prepare
> >a patch on top of yours?
> >
> >bye,
> >Sumit
>
> Hi,
> new patches are attached.
>
Thank you.
Please apply the following change to avoid a compiler warning:
diff --git a/src/tests/cmocka/test_sss_sifp.c b/src/tests/cmocka/test_sss_sifp.c
index d22f7af..190dd76 100644
--- a/src/tests/cmocka/test_sss_sifp.c
+++ b/src/tests/cmocka/test_sss_sifp.c
@@ -48,7 +48,7 @@
__wrap_dbus_connection_send_with_reply_and_block(DBusConnection *connection,
return NULL;
}
- return sss_mock_type(DBusMessage *);
+ return sss_mock_ptr_type(DBusMessage *);
}
In sss_sifp.h you can remove '#include <dbus/dbus.h>' and the
declarations of sss_sifp_create_message(), sss_sifp_send_message(),
sss_sifp_send_message_ex(), sss_sifp_invoke_list() and
sss_sifp_invoke_find() because they are now available in
sss_sifp_dbus.h.
bye,
Sumit
> _______________________________________________
> sssd-devel mailing list
> sssd-devel@lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
