On Wed, May 28, 2014 at 11:37:50AM +0200, Jakub Hrozek wrote: > On Wed, May 28, 2014 at 11:05:38AM +0200, Pavel Březina wrote: > > On 05/28/2014 10:48 AM, Jakub Hrozek wrote: > > >On Tue, May 27, 2014 at 10:28:42PM +0200, Pavel Březina wrote: > > >>Hi, > > >>I'm starting a new thread branch, since the review mails got kind of > > >>separated and it starts to be confusing. > > >> > > >>I'm sending new patch set including also Jakub's tests, all issues > > >>should be fixed. > > >> > > >>Ack to all Jakub's patches. > > > > > >Squash in the following patch to the ifp_domains code and I'll ack :-) > > > > Thanks. New patches are attached. > > > > These work fine. > > ACK
..or not. Lukas found out that there are Coverity warnings. The attached patches fix them.
>From 9e8f12c809823f4b7399734005ede6d4547d0510 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek <[email protected]> Date: Wed, 28 May 2014 13:14:20 +0200 Subject: [PATCH] fixup for components --- src/responder/ifp/ifp_components.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/responder/ifp/ifp_components.c b/src/responder/ifp/ifp_components.c index c90abe18793283c43b0aec2bf338c9ebdd569b56..56fd566ed2baa5acf2435148ab5e724651c631dd 100644 --- a/src/responder/ifp/ifp_components.c +++ b/src/responder/ifp/ifp_components.c @@ -440,7 +440,8 @@ int ifp_find_backend_by_name(struct sbus_request *dbus_req, ctx = talloc_get_type(data, struct ifp_ctx); if (ctx == NULL) { DEBUG(SSSDBG_CRIT_FAILURE, "Invalid ifp context!\n"); - error = sbus_error_new(dbus_req, DBUS_ERROR_FAILED, strerror(EINVAL)); + error = sbus_error_new(dbus_req, DBUS_ERROR_FAILED, + "%s\n", strerror(EINVAL)); return sbus_request_fail_and_finish(dbus_req, error); } -- 1.9.0
>From 313623150e661105388af95c906488866236b97a Mon Sep 17 00:00:00 2001 From: Jakub Hrozek <[email protected]> Date: Wed, 28 May 2014 14:11:54 +0200 Subject: [PATCH] Return dbus error if set --- src/responder/ifp/ifp_components.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/responder/ifp/ifp_components.c b/src/responder/ifp/ifp_components.c index 56fd566ed2baa5acf2435148ab5e724651c631dd..e5fa06cdd23fa9dcb3e3601a670a73857e4fc33d 100644 --- a/src/responder/ifp/ifp_components.c +++ b/src/responder/ifp/ifp_components.c @@ -519,6 +519,8 @@ done: if (ret == ENOMEM) { return sbus_request_fail_and_finish(dbus_req, NULL); + } else if (error != NULL) { + return sbus_request_fail_and_finish(dbus_req, error); } else if (ret != EOK) { error = sbus_error_new(dbus_req, DBUS_ERROR_FAILED, "%s", strerror(ret)); return sbus_request_fail_and_finish(dbus_req, error); @@ -588,6 +590,8 @@ done: if (ret == ENOMEM) { return sbus_request_fail_and_finish(dbus_req, NULL); + } else if (error != NULL) { + return sbus_request_fail_and_finish(dbus_req, error); } else if (ret != EOK) { error = sbus_error_new(dbus_req, DBUS_ERROR_FAILED, "%s", strerror(ret)); return sbus_request_fail_and_finish(dbus_req, error); -- 1.9.0
_______________________________________________ sssd-devel mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
