On Fri, Jul 18, 2014 at 05:02:33PM +0200, Lukas Slebodnik wrote:
> On (15/07/14 17:28), Jakub Hrozek wrote:
> >On Mon, Jul 14, 2014 at 10:10:59PM +0300, Noam Meltzer wrote:
> >> On Mon, Jul 14, 2014 at 7:30 PM, Jakub Hrozek <jhro...@redhat.com> wrote:
> >>
> >> > On Fri, Jun 27, 2014 at 09:44:38AM +0300, Noam Meltzer wrote:
> >> > > ---
> >> > > contrib/sssd.spec.in | 7 +++++++
> >> > > 1 file changed, 7 insertions(+)
> >> > >
> >> > > diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in
> >> > > index b5e7903..8d2f2be 100644
> >> > > --- a/contrib/sssd.spec.in
> >> > > +++ b/contrib/sssd.spec.in
> >> > > @@ -138,6 +138,11 @@ BuildRequires: systemd-devel
> >> > > %if (0%{?with_cifs_utils_plugin} == 1)
> >> > > BuildRequires: cifs-utils-devel
> >> > > %endif
> >> > > +%if ((0%{?fedora} >= 15) || (0%{?rhel} >= 7))
> >> > > +BuildRequires: libnfsidmap-devel
> >> > > +%else
> >> > > +BuildRequires: nfs-utils-lib-devel
> >> > > +%endif
> >> > >
> >> > > # RHEL 5 is too old to support samba4 and the PAC responder
> >> > > %if !0%{?is_rhel5}
> >> > > @@ -451,6 +456,7 @@ autoreconf -ivf
> >> > > --with-krb5-rcache-dir=%{_localstatedir}/cache/krb5rcache \
> >> > > --enable-nsslibdir=/%{_lib} \
> >> > > --enable-pammoddir=/%{_lib}/security \
> >> > > + --enable-nfsidmaplibdir=%{_libdir}/libnfsidmap \
> >> > > --disable-static \
> >> > > --disable-rpath \
> >> > > %{?with_ccache} \
> >> > > @@ -600,6 +606,7 @@ rm -rf $RPM_BUILD_ROOT
> >> > > # 3rd party application libraries
> >> > > %{_libdir}/sssd/modules/libsss_autofs.so
> >> > > %{_libdir}/libsss_sudo.so
> >> > > +%{_libdir}/libnfsidmap/sss_nfs.so
> >> >
> >> > Here I've got a question, the directory %{_libdir}/libnfsidmap seems not
> >> > to be owned by any package, at least on Fedora-20, however the
> >> > individual files are:
> >> > $ rpm -qf /usr/lib64/libnfsidmap/
> >> > file /usr/lib64/libnfsidmap is not owned by any package
> >> > $ rpm -qf /usr/lib64/libnfsidmap/nsswitch.so
> >> > libnfsidmap-0.25-8.fc20.x86_64
> >> >
> >> > The reason I'm curious is that initially I wanted to Require the package
> >> > that owns this directory..
> >> >
> >> > Do you agree this is a packaging bug of libnfsidmap ?
> >> >
> >>
> >> I agree
> >
> >It's been filed for some time already:
> > https://bugzilla.redhat.com/show_bug.cgi?id=986678
> >>
> >>
> >> >
> >> > Otherwise ACK to your patch.
> >
> >Actually, I think we should also add:
> > Requires: libnfsidmap
> >to the spec file.
> >
> This requirement is automatically detected by rpm.
>
> sh-4.2$ rpm -q --requires -p sssd-common-1.12.1-0.el6.x86_64.rpm | grep nfs
> libnfsidmap.so.0()(64bit)
>
> sh-4.2$ rpm -qf /lib64/libnfsidmap.so.0
> libnfsidmap-0.25-8.fc20.x86_64
>
> sh-4.2$ rpm -q --provides libnfsidmap
> config(libnfsidmap) = 0.25-8.fc20
> libnfsidmap = 0.25-8.fc20
> libnfsidmap(x86-64) = 0.25-8.fc20
> libnfsidmap.so.0()(64bit)
> nfs-utils-lib
Yes, but we do depend on a filesystem path. Isn't it safer to explicitly
require it?
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
