On Wed, Aug 27, 2014 at 11:31:27AM +0200, Lukas Slebodnik wrote:
> On (21/08/14 13:38), Sumit Bose wrote:
> >On Thu, Aug 21, 2014 at 01:27:58PM +0200, Jakub Hrozek wrote:
> >> On Wed, Aug 20, 2014 at 05:38:56PM +0200, Sumit Bose wrote:
> >> > > > wbcGetgrnam and wbcGetgrnam have wrong comments, but this trivial
> >> > > > bug is
> >> > > > also in Samba.
> >> > > >
> >> > > > Are you sure the asprintf() call in wbcLookupName is safe? Could this
> >> > > > enable someone to trash the stack with a long enough name?
> >> > >
> >> > > I added some checks to prevent this.
> >>
> >> For some reason I thought that asprintf allocates on the stack like
> >> alloca and didn't see the call to free. In this case, I don't think the
> >> check is needed.
> >
> >I think the NULL checks still make sense and if you agree I would keep
> >the others just as sanity checks.
> >
>
> libwbclient is installed by default with make install
> and there isn't way how to disable this behaviour.
> Should we add possibility to build (or install) library optionaly?
> It might help package maintainers.
Do you think attached patch would work?
bye,
Sumit
>
> LS
> _______________________________________________
> sssd-devel mailing list
> sssd-devel@lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
From b92a817a5b984216f85ceb89f60e554a50d1c2e5 Mon Sep 17 00:00:00 2001
From: Sumit Bose <sb...@redhat.com>
Date: Wed, 27 Aug 2014 18:27:07 +0200
Subject: [PATCH] libwbclient: make build optional
---
Makefile.am | 5 ++++-
configure.ac | 1 +
src/conf_macros.m4 | 16 ++++++++++++++++
3 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 1b183d0..dd0ddb3 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -733,9 +733,12 @@ endif # BUILD_IFP
lib_LTLIBRARIES = libipa_hbac.la \
libsss_idmap.la \
libsss_nss_idmap.la \
- libwbclient.la \
$(NULL)
+if BUILD_LIBWBCLIENT
+lib_LTLIBRARIES += libwbclient.la
+endif #BUILD_LIBWBCLIENT
+
pkgconfig_DATA += src/providers/ipa/ipa_hbac.pc
libipa_hbac_la_DEPENDENCIES = src/providers/ipa/ipa_hbac.exports
libipa_hbac_la_SOURCES = \
diff --git a/configure.ac b/configure.ac
index d20cb9c..7a94272 100644
--- a/configure.ac
+++ b/configure.ac
@@ -123,6 +123,7 @@ WITH_IFP
WITH_CRYPTO
WITH_SYSLOG
WITH_SAMBA
+WITH_LIBWBCLIENT
m4_include([src/external/pkg.m4])
m4_include([src/external/libpopt.m4])
diff --git a/src/conf_macros.m4 b/src/conf_macros.m4
index 3c9827b..0bc94f9 100644
--- a/src/conf_macros.m4
+++ b/src/conf_macros.m4
@@ -669,6 +669,22 @@ AC_DEFUN([WITH_IFP],
AM_CONDITIONAL([BUILD_IFP], [test x"$with_infopipe" = xyes])
])
+AC_DEFUN([WITH_LIBWBCLIENT],
+ [ AC_ARG_WITH([libwbclient],
+ [AC_HELP_STRING([--with-libwbclient],
+ [Whether to build SSSD implementation of
libwbclient [yes]]
+ )
+ ],
+ [with_libwbclient=$withval],
+ with_libwbclient=yes
+ )
+
+ if test x"$with_libwbclient" = xyes; then
+ AC_DEFINE(BUILD_LIBWBCLIENT, 1, [whether to build SSSD implementation
of libwbclient])
+ fi
+ AM_CONDITIONAL([BUILD_LIBWBCLIENT], [test x"$with_libwbclient" = xyes])
+ ])
+
AC_DEFUN([WITH_SAMBA],
[ AC_ARG_WITH([samba],
[AC_HELP_STRING([--with-samba],
--
1.8.3.1
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
