On Thu, Aug 28, 2014 at 06:24:23PM +0200, Lukas Slebodnik wrote:
> >This test ran OK this time, so I think you are right.
> >
> >I have some comments to the patch itself.
> >
> >I'm not personally fan of big patches like this one. Could you at least
> >separate the man page changes to separate patch - so we can ask some native
> >speaker to review it.
> I am not big fan of splitting patches just for "man page changes"

me neither, backporting or cherry-picking is then harder.

Patches should do one logical change.
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to