On (02/12/14 13:17), Pavel Reichl wrote:
>
>On 12/02/2014 01:09 PM, Lukas Slebodnik wrote:
>>On (01/12/14 13:49), Pavel Reichl wrote:
>>>START_TEST (test_sysdb_attrs_to_list)
>>>{
>>> struct sysdb_attrs *attrs_list[3];
>>>@@ -4907,10 +4959,9 @@ START_TEST(test_sysdb_has_enumerated)
>>> fail_if(ret != EOK, "Could not set up the test");
>>>
>>> ret = sysdb_has_enumerated(test_ctx->domain, &enumerated);
>>>- fail_if(ret != EOK, "Error [%d][%s] checking enumeration",
>>>- ret, strerror(ret));
>>>-
>>>- fail_if(enumerated, "Enumeration should default to false");
>>>+ fail_if(ret != ENOENT,
>>>+ "Error [%d][%s] checking enumeration ENOENT is expected",
>>>+ ret, strerror(ret));
>>>
>>> ret = sysdb_set_enumerated(test_ctx->domain, true);
>>> fail_if(ret != EOK, "Error [%d][%s] setting enumeration",
>>>@@ -6231,6 +6282,9 @@ Suite *create_sysdb_suite(void)
>>> tcase_add_loop_test(tc_memberof, test_sysdb_remove_local_group_by_gid,
>>> MBO_GROUP_BASE , MBO_GROUP_BASE + 10);
>>>
>>>+ /* Misc */
>>>+ tcase_add_test(tc_sysdb, test_sysdb_set_get_bool);
>>>+
>>Almost ACK.
>>
>>Could you move this line among other test from test case sysdb (tc_sysdb)
>>The test test_sysdb_set_get_bool is added to test case tc_sysdb,
>>but us between two tests from test case tc_memberof
>OK
>>> /* Ghost users tests */
>>> tcase_add_loop_test(tc_memberof,
>>> test_sysdb_memberof_store_group_with_ghosts,
>>> MBO_GROUP_BASE , MBO_GROUP_BASE + 10);
>>LS
>
>From 5317f6d858d017e538447ca4b0480d024895ef02 Mon Sep 17 00:00:00 2001
>From: Pavel Reichl <prei...@redhat.com>
>Date: Tue, 4 Nov 2014 08:52:54 +0000
>Subject: [PATCH] SYSDB: sysdb_get_bool() return ENOENT & unit tests
>
>sysdb_get_bool() return ENOENT if no result is found.
>Unit test for sysdb_get_bool() & sysdb_set_bool() was added.
>
>This patch also fixes ldap_setup_enumeration() to handle ENOENT returned by
>sysdb_has_enumerated().
>
>Resolves:
>https://fedorahosted.org/sssd/ticket/1991
>---
ACK
LS
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
