----- Original Message -----
> From: "Jakub Hrozek" <jhro...@redhat.com>
> To: sssd-devel@lists.fedorahosted.org
> Sent: Wednesday, January 14, 2015 4:19:15 PM
> Subject: Re: [SSSD] [PATCH] MAN: Remove indentation in element 
> programlistening
> 
> On Wed, Jan 14, 2015 at 09:10:29AM -0500, Roland Mainz wrote:
> > 
> > 
> > ----- Original Message -----
> > > From: "Lukas Slebodnik" <lsleb...@redhat.com>
> > > To: sssd-devel@lists.fedorahosted.org
> > > Sent: Wednesday, January 14, 2015 2:11:22 PM
> > > Subject: [SSSD] [PATCH] MAN: Remove indentation in element
> > > programlistening
> > > 
> > > ehlo,
> > > 
> > > I noticed that indentation of examples for ad_gpo_map_* is realy weird.
> > 
> > That's the expected behaviour with <programlisting> vs. space/tab/etc
> > characters - leading spaces/tabs/etc. are part of the formatting.
> > 
> > > attached is a simple patch which just remove whitespaces.
> > [snip]
> > 
> > Patch looks good to me, r=rma...@redhat.com
> 
> Thank you for the review, pushed to master as
> ecf9e7a870945ecfba8eb751d344de3601de9424

BTW: In the future it may be interesting to use XInclude for longer 
<programlisting> chunks to prevent the quoting (and layout) hell - see 
https://lists.fedorahosted.org/pipermail/sssd-devel/2015-January/022352.html 
("[SSSD] Using XInclude for DocBook/XML manpages ... / was: Re: xml schema used 
for generating man pages") for examples...

----

Bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) rma...@redhat.com
  \__\/\/__/  IPA/Kerberos5 team
  /O /==\ O\  
 (;O/ \/ \O;)
 
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to