On (29/01/15 10:27), Pavel Reichl wrote:
>On 01/29/2015 08:16 AM, Lukas Slebodnik wrote:
>>ehlo,
>>
>>the patch for ticket "functions with reference leaks within sssd"
>>#1195 was not tested proerly and double free was introduced.
>>
>>Simple patch is attached.
>>
>>LS
>>
>Thank you for the patch and I'm sorry for missing that. Patch looks good to
>me.
>
>Running without the patch 'python python-test.py' yields 'Aborted (core
>dumped)' and valgrind finds errors (ERROR SUMMARY: 2 errors from 2 contexts)
>
>After applying the patch no core dump is happening and valgrind finds 0
>errors.
>
>ACK
Thank you for review.

Could you attach link to CI results?
I prefer reviewer attach links.

LS
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to