On (18/02/15 09:45), Lukas Slebodnik wrote:
>On (17/02/15 16:43), Lukas Slebodnik wrote:
>>ehlo,
>>
>>Attached patch should simplify analysis of log files.
>>It should be applied to 1-12 branch. I will generate another version for
>>master
>>after merging all pending big patchsets.
>>
>>LS
>
>Attached is updated version which remove extra new line added
>in logging of nsupdate message.
>
>LS
>From fb63af5174b35f9f5f873a0be04cdc840eb1ac0b Mon Sep 17 00:00:00 2001
>From: Lukas Slebodnik <lsleb...@redhat.com>
>Date: Tue, 17 Feb 2015 16:40:01 +0100
>Subject: [PATCH] Add missing new lines to debug messages
>
I send wrong patch which was not able to compile.
src/providers/dp_dyndns.c: In function ‘be_nsupdate_create_ptr_msg’:
src/providers/dp_dyndns.c:1207:0: error: unterminated argument list invoking
macro "DEBUG"
}
^
../sssd/src/providers/dp_dyndns.c:525:5: error: ‘DEBUG’ undeclared (first use
in this function)
DEBUG(SSSDBG_TRACE_FUNC,
^
src/providers/dp_dyndns.c:525:5: note: each undeclared identifier is reported
only once for each function it appears in
src/providers/dp_dyndns.c:525:5: error: expected ‘;’ at end of input
src/providers/dp_dyndns.c:525:5: error: expected declaration or statement at
end of input
src/providers/dp_dyndns.c:517:9: error: label ‘done’ used but not defined
goto done;
^
src/providers/dp_dyndns.c:499:13: error: variable ‘ret’ set but not used
[-Werror=unused-but-set-variable]
errno_t ret;
^
src/providers/dp_dyndns.c:525:5: error: control reaches end of non-void
function [-Werror=return-type]
DEBUG(SSSDBG_TRACE_FUNC,
^
cc1: all warnings being treated as errors
LS
>From f356fdca6a2863ff5ea03f97617198f94af3d13f Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lsleb...@redhat.com>
Date: Tue, 17 Feb 2015 16:40:01 +0100
Subject: [PATCH] Add missing new lines to debug messages
---
src/confdb/confdb_setup.c | 2 +-
src/db/sysdb_autofs.c | 4 ++--
src/db/sysdb_sudo.c | 2 +-
src/db/sysdb_views.c | 4 ++--
src/monitor/monitor.c | 6 +++---
src/monitor/monitor_netlink.c | 16 ++++++++--------
src/providers/ad/ad_common.c | 8 ++++----
src/providers/ad/ad_init.c | 8 ++++----
src/providers/ad/ad_subdomains.c | 4 ++--
src/providers/data_provider_be.c | 6 +++---
src/providers/dp_dyndns.c | 16 ++++++++--------
src/providers/dp_ptask.c | 10 ++++++----
src/providers/ipa/ipa_access.c | 2 +-
src/providers/ipa/ipa_hbac_rules.c | 2 +-
src/providers/ipa/ipa_hostid.c | 2 +-
src/providers/ipa/ipa_selinux.c | 6 +++---
src/providers/ipa/ipa_subdomains.c | 6 +++---
src/providers/ipa/ipa_subdomains_ext_groups.c | 6 +++---
src/providers/krb5/krb5_child.c | 2 +-
src/providers/krb5/krb5_wait_queue.c | 2 +-
src/providers/ldap/ldap_id.c | 2 +-
src/providers/ldap/sdap.c | 4 ++--
src/providers/ldap/sdap_access.c | 2 +-
src/providers/ldap/sdap_async.c | 2 +-
src/providers/ldap/sdap_async_connection.c | 2 +-
src/providers/ldap/sdap_async_initgroups.c | 6 +++---
src/providers/ldap/sdap_utils.c | 2 +-
src/responder/autofs/autofssrv_cmd.c | 4 ++--
src/responder/common/responder_dp.c | 4 ++--
src/responder/nss/nsssrv_cmd.c | 4 ++--
src/responder/nss/nsssrv_netgroup.c | 4 ++--
src/responder/pac/pacsrv_cmd.c | 18 ++++++++----------
src/responder/pac/pacsrv_utils.c | 4 ++--
src/responder/pam/pamsrv.c | 4 ++--
src/responder/sudo/sudosrv_get_sudorules.c | 2 +-
src/responder/sudo/sudosrv_query.c | 2 +-
src/sbus/sssd_dbus_server.c | 4 ++--
src/tests/krb5_child-test.c | 2 +-
src/tools/files.c | 12 ++++++------
src/tools/sss_cache.c | 9 +++++----
src/tools/sss_sync_ops.c | 2 +-
src/util/debug.c | 2 +-
src/util/domain_info_utils.c | 18 ++++++++++--------
src/util/find_uid.c | 2 +-
src/util/server.c | 4 ++--
src/util/sss_ini.c | 4 ++--
src/util/sss_krb5.c | 10 +++++-----
src/util/sss_semanage.c | 7 ++++---
src/util/usertools.c | 2 +-
49 files changed, 131 insertions(+), 127 deletions(-)
diff --git a/src/confdb/confdb_setup.c b/src/confdb/confdb_setup.c
index
857725f1a80219045b1fd9bfb6e24f95f8f06c1a..93a1a1b53ab0c9d76ecb35cf186624770088b425
100644
--- a/src/confdb/confdb_setup.c
+++ b/src/confdb/confdb_setup.c
@@ -275,7 +275,7 @@ int confdb_init_db(const char *config_file, struct
confdb_ctx *cdb)
goto done;
}
- DEBUG(SSSDBG_TRACE_LIBS, "LDIF file to import: \n%s", config_ldif);
+ DEBUG(SSSDBG_TRACE_LIBS, "LDIF file to import: \n%s\n", config_ldif);
while ((ldif = ldb_ldif_read_string(cdb->ldb, &config_ldif))) {
ret = ldb_add(cdb->ldb, ldif->msg);
diff --git a/src/db/sysdb_autofs.c b/src/db/sysdb_autofs.c
index
218e9c0a09a6b274d9154d5d084b87c229811bce..b3e9b4ec83b66ec65a72ab7a3180106e2293d8a5
100644
--- a/src/db/sysdb_autofs.c
+++ b/src/db/sysdb_autofs.c
@@ -222,7 +222,7 @@ sysdb_get_map_byname(TALLOC_CTX *mem_ctx,
&count, &msgs);
if (ret != EOK && ret != ENOENT) {
DEBUG(SSSDBG_CRIT_FAILURE,
- "Error looking up autofs map [%s]", safe_map_name);
+ "Error looking up autofs map [%s]\n", safe_map_name);
goto done;
} else if (ret == ENOENT) {
DEBUG(SSSDBG_TRACE_FUNC, "No such map\n");
@@ -467,7 +467,7 @@ sysdb_invalidate_autofs_maps(struct sss_domain_info *domain)
&count, &msgs);
if (ret != EOK && ret != ENOENT) {
DEBUG(SSSDBG_CRIT_FAILURE,
- "Error looking up autofs maps");
+ "Error looking up autofs maps\n");
goto done;
} else if (ret == ENOENT) {
ret = EOK;
diff --git a/src/db/sysdb_sudo.c b/src/db/sysdb_sudo.c
index
261ed82d672cd95f0c0f429a177dae39d3b9c204..d62234f9b18cff44e935bfef6dda612a98f09e5a
100644
--- a/src/db/sysdb_sudo.c
+++ b/src/db/sysdb_sudo.c
@@ -663,7 +663,7 @@ errno_t sysdb_sudo_purge_byfilter(struct sss_domain_info
*domain,
ret = EOK;
goto done;
} else if (ret != EOK) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Error looking up SUDO rules");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Error looking up SUDO rules\n");
goto done;
}
diff --git a/src/db/sysdb_views.c b/src/db/sysdb_views.c
index
717edf20a447003568060cf4d32bf8d47bd93e63..21c64c4818d0946785921edbe7c4047d09b0f2a2
100644
--- a/src/db/sysdb_views.c
+++ b/src/db/sysdb_views.c
@@ -165,7 +165,7 @@ errno_t sysdb_update_view_name(struct sysdb_ctx *sysdb,
ret = ldb_add(sysdb->ldb, msg);
}
if (ret != LDB_SUCCESS) {
- DEBUG(SSSDBG_FATAL_FAILURE, "Failed to %s view container",
+ DEBUG(SSSDBG_FATAL_FAILURE, "Failed to %s view container\n",
view_container_exists ? "modify" : "add");
ret = sysdb_error_to_errno(ret);
goto done;
@@ -236,7 +236,7 @@ errno_t sysdb_invalidate_overrides(struct sysdb_ctx *sysdb)
base_dn = ldb_dn_new(tmp_ctx, sysdb->ldb, SYSDB_BASE);
if (base_dn == NULL) {
- DEBUG(SSSDBG_OP_FAILURE, "ldb_dn_new failed");
+ DEBUG(SSSDBG_OP_FAILURE, "ldb_dn_new failed\n");
ret = ENOMEM;
goto done;
}
diff --git a/src/monitor/monitor.c b/src/monitor/monitor.c
index
f171c05acd2c770ab9ffad2429d92c5041bcdb59..5611bb9eab04299b5d1d6c2a17fadaaed3335f99
100644
--- a/src/monitor/monitor.c
+++ b/src/monitor/monitor.c
@@ -998,9 +998,9 @@ static int get_monitor_config(struct mt_ctx *ctx)
ret = add_implicit_services(ctx->cdb, ctx, &ctx->services);
if (ret != EOK) {
- DEBUG(SSSDBG_OP_FAILURE, "Failed to add implicit configured " \
- "services. Some functionality might " \
- "be missing");
+ DEBUG(SSSDBG_OP_FAILURE, "Failed to add implicit configured "
+ "services. Some functionality might "
+ "be missing\n");
}
badsrv = check_services(ctx->services);
diff --git a/src/monitor/monitor_netlink.c b/src/monitor/monitor_netlink.c
index
51e8ffe4725ac2943b39bf229022d2637b799cea..7e6f8cbbd3c4815fb2c9991698ecfd4ee5deeeef
100644
--- a/src/monitor/monitor_netlink.c
+++ b/src/monitor/monitor_netlink.c
@@ -220,7 +220,7 @@ static bool has_phy_80211_subdir(const char *sysfs_path)
ret = snprintf(phy80211_path, SYSFS_SUBDIR_PATH_MAX,
"%s/%s", sysfs_path, PHY_80211_SUBDIR);
if (ret < 0) {
- DEBUG(SSSDBG_OP_FAILURE, "snprintf failed");
+ DEBUG(SSSDBG_OP_FAILURE, "snprintf failed\n");
return false;
} else if (ret >= SYSFS_SUBDIR_PATH_MAX) {
DEBUG(SSSDBG_OP_FAILURE, "path too long?!?!\n");
@@ -263,7 +263,7 @@ static bool discard_iff_up(const char *ifname)
ret = snprintf(path, SYSFS_IFACE_PATH_MAX, SYSFS_IFACE_TEMPLATE, ifname);
if (ret < 0) {
- DEBUG(SSSDBG_OP_FAILURE, "snprintf failed");
+ DEBUG(SSSDBG_OP_FAILURE, "snprintf failed\n");
return false;
} else if (ret >= SYSFS_IFACE_PATH_MAX) {
DEBUG(SSSDBG_OP_FAILURE, "path too long?!?!\n");
@@ -339,8 +339,8 @@ static bool nlw_accept_message(struct nlw_handle *nlp,
}
if (accept_msg == false) {
- DEBUG(SSSDBG_TRACE_ALL, "ignoring netlink message from PID %d",
- hdr->nlmsg_pid);
+ DEBUG(SSSDBG_TRACE_ALL,
+ "ignoring netlink message from PID %d\n", hdr->nlmsg_pid);
}
return accept_msg;
@@ -475,8 +475,8 @@ static int event_msg_recv(struct nl_msg *msg, void *arg)
creds = nlmsg_get_creds(msg);
if (!creds || creds->uid != 0) {
DEBUG(SSSDBG_TRACE_ALL,
- "Ignoring netlink message from UID %"SPRIuid,
- creds ? creds->uid : (uid_t)-1);
+ "Ignoring netlink message from UID %"SPRIuid"\n",
+ creds ? creds->uid : (uid_t)-1);
return NL_SKIP;
}
@@ -754,8 +754,8 @@ int setup_netlink(TALLOC_CTX *mem_ctx, struct
tevent_context *ev,
/* allocate the libnl handle/socket and register the default filter set */
nlctx->nlp = nlw_alloc();
if (!nlctx->nlp) {
- DEBUG(SSSDBG_CRIT_FAILURE, ("unable to allocate netlink handle: %s"),
- nlw_geterror(ENOMEM));
+ DEBUG(SSSDBG_CRIT_FAILURE,
+ "unable to allocate netlink handle: %s\n", nlw_geterror(ENOMEM));
ret = ENOMEM;
goto fail;
}
diff --git a/src/providers/ad/ad_common.c b/src/providers/ad/ad_common.c
index
c3cbfdac06b1e89c35ceb7547f5a31ca85bbb28f..120878977d08aab04bbd9e3cf87a00a4b018b6e4
100644
--- a/src/providers/ad/ad_common.c
+++ b/src/providers/ad/ad_common.c
@@ -437,8 +437,8 @@ _ad_servers_init(struct ad_service *service,
false, sdata);
if (ret != EOK) {
DEBUG(SSSDBG_FATAL_FAILURE,
- "Failed to add service discovery to failover: [%s]",
- strerror(ret));
+ "Failed to add service discovery to failover: [%s]\n",
+ strerror(ret));
goto done;
}
@@ -454,8 +454,8 @@ _ad_servers_init(struct ad_service *service,
false, sdata);
if (ret != EOK) {
DEBUG(SSSDBG_FATAL_FAILURE,
- "Failed to add service discovery to failover: [%s]",
- strerror(ret));
+ "Failed to add service discovery to failover: [%s]\n",
+ strerror(ret));
goto done;
}
diff --git a/src/providers/ad/ad_init.c b/src/providers/ad/ad_init.c
index
2de7e0a44015750c7a4c7980d4ebeb26736c4f02..2636b1aba6f005325416e2500b0fd9fb24081260
100644
--- a/src/providers/ad/ad_init.c
+++ b/src/providers/ad/ad_init.c
@@ -457,16 +457,16 @@ sssm_ad_access_init(struct be_ctx *bectx,
ret = sss_hash_create(access_ctx, 10, &access_ctx->gpo_map_options_table);
if (ret != EOK) {
DEBUG(SSSDBG_FATAL_FAILURE,
- "Could not create gpo_map_options hash table: [%s]",
- strerror(ret));
+ "Could not create gpo_map_options hash table: [%s]\n",
+ strerror(ret));
goto fail;
}
ret = ad_gpo_parse_map_options(access_ctx);
if (ret != EOK) {
DEBUG(SSSDBG_FATAL_FAILURE,
- "Could not parse gpo_map_options (invalid config): [%s]",
- strerror(ret));
+ "Could not parse gpo_map_options (invalid config): [%s]\n",
+ strerror(ret));
goto fail;
}
diff --git a/src/providers/ad/ad_subdomains.c b/src/providers/ad/ad_subdomains.c
index
b3821f8d07855e431e69cdc00c225bcd7e4db1eb..5a6e9338d6dc581fba4f76e8b28f92a558eb6294
100644
--- a/src/providers/ad/ad_subdomains.c
+++ b/src/providers/ad/ad_subdomains.c
@@ -1186,12 +1186,12 @@ int ad_subdom_init(struct be_ctx *be_ctx,
ret = be_add_online_cb(ctx, be_ctx, ad_subdom_online_cb, ctx, NULL);
if (ret != EOK) {
- DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom online callback");
+ DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom online callback\n");
}
ret = be_add_offline_cb(ctx, be_ctx, ad_subdom_offline_cb, ctx, NULL);
if (ret != EOK) {
- DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom offline callback");
+ DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom offline callback\n");
}
err = sss_idmap_init(sss_idmap_talloc, ctx, sss_idmap_talloc_free,
diff --git a/src/providers/data_provider_be.c b/src/providers/data_provider_be.c
index
95df2d9c645025a47176a9956e6069ec53dc2391..9a752e31ed2d644fd590d9a556d5c4f9cc17c4f6
100644
--- a/src/providers/data_provider_be.c
+++ b/src/providers/data_provider_be.c
@@ -499,7 +499,7 @@ void be_mark_offline(struct be_ctx *ctx)
if (ret != EOK) {
DEBUG(SSSDBG_CRIT_FAILURE,
"Failed to get offline_timeout from confdb. "
- "Will use 60 seconds.");
+ "Will use 60 seconds.\n");
offline_timeout = 60;
}
ret = be_ptask_create_sync(ctx, ctx,
@@ -926,7 +926,7 @@ be_file_account_request(struct be_req *be_req, struct
be_acct_req *ar)
if ((ar->entry_type & 0xFF) == BE_REQ_INITGROUPS) {
ret = be_initgroups_prereq(be_req);
if (ret) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Prerequest failed");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Prerequest failed\n");
return ret;
}
}
@@ -935,7 +935,7 @@ be_file_account_request(struct be_req *be_req, struct
be_acct_req *ar)
ret = be_file_request(be_ctx, be_req,
be_ctx->bet_info[BET_ID].bet_ops->handler);
if (ret != EOK) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Failed to file request");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Failed to file request\n");
return ret;
}
diff --git a/src/providers/dp_dyndns.c b/src/providers/dp_dyndns.c
index
f7385d5a7f6be0d8f2a7fd248edf69175f411baa..a051a23a999e0b578181f980d9aea18edc96fa01
100644
--- a/src/providers/dp_dyndns.c
+++ b/src/providers/dp_dyndns.c
@@ -476,10 +476,10 @@ be_nsupdate_create_fwd_msg(TALLOC_CTX *mem_ctx, const
char *realm,
}
DEBUG(SSSDBG_TRACE_FUNC,
- " -- Begin nsupdate message -- \n%s",
- update_msg);
- DEBUG(SSSDBG_TRACE_FUNC,
- " -- End nsupdate message -- \n");
+ " -- Begin nsupdate message -- \n"
+ "%s"
+ " -- End nsupdate message -- \n",
+ update_msg);
ret = ERR_OK;
*_update_msg = talloc_steal(mem_ctx, update_msg);
@@ -518,10 +518,10 @@ be_nsupdate_create_ptr_msg(TALLOC_CTX *mem_ctx, const
char *realm,
}
DEBUG(SSSDBG_TRACE_FUNC,
- " -- Begin nsupdate message -- \n%s",
- update_msg);
- DEBUG(SSSDBG_TRACE_FUNC,
- " -- End nsupdate message -- \n");
+ " -- Begin nsupdate message -- \n"
+ "%s"
+ " -- End nsupdate message -- \n",
+ update_msg);
ret = ERR_OK;
*_update_msg = talloc_steal(mem_ctx, update_msg);
diff --git a/src/providers/dp_ptask.c b/src/providers/dp_ptask.c
index
e3450851e095ded7994ab8bb58031e0b3a22593c..0f28dee1ed8e6683dbdb82d9274d18a10108cbd6
100644
--- a/src/providers/dp_ptask.c
+++ b/src/providers/dp_ptask.c
@@ -317,15 +317,17 @@ errno_t be_ptask_create(TALLOC_CTX *mem_ctx,
/* install offline and online callbacks */
ret = be_add_online_cb(task, be_ctx, be_ptask_online_cb, task, NULL);
if (ret != EOK) {
- DEBUG(SSSDBG_OP_FAILURE, "Unable to install online callback "
- "[%d]: %s", ret, sss_strerror(ret));
+ DEBUG(SSSDBG_OP_FAILURE,
+ "Unable to install online callback [%d]: %s\n",
+ ret, sss_strerror(ret));
goto done;
}
ret = be_add_offline_cb(task, be_ctx, be_ptask_offline_cb, task, NULL);
if (ret != EOK) {
- DEBUG(SSSDBG_OP_FAILURE, "Unable to install offline callback "
- "[%d]: %s", ret, sss_strerror(ret));
+ DEBUG(SSSDBG_OP_FAILURE,
+ "Unable to install offline callback [%d]: %s\n",
+ ret, sss_strerror(ret));
goto done;
}
}
diff --git a/src/providers/ipa/ipa_access.c b/src/providers/ipa/ipa_access.c
index
ed52132ad51fb89eb428233037e623fbbcad13ca..2ebaec337eedd205bab7c7cbb2a77568616062d0
100644
--- a/src/providers/ipa/ipa_access.c
+++ b/src/providers/ipa/ipa_access.c
@@ -711,7 +711,7 @@ errno_t hbac_get_cached_rules(TALLOC_CTX *mem_ctx,
HBAC_RULES_SUBDIR, attrs,
&rule_count, &msgs);
if (ret != EOK && ret != ENOENT) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Error looking up HBAC rules");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Error looking up HBAC rules\n");
goto done;
} if (ret == ENOENT) {
rule_count = 0;
diff --git a/src/providers/ipa/ipa_hbac_rules.c
b/src/providers/ipa/ipa_hbac_rules.c
index
571b90c5813b9b1a7d38d70c4c61604b6e64f0e4..72c8d73d498fec305cdef296dfaedcb2461d4669
100644
--- a/src/providers/ipa/ipa_hbac_rules.c
+++ b/src/providers/ipa/ipa_hbac_rules.c
@@ -144,7 +144,7 @@ ipa_hbac_rule_info_send(TALLOC_CTX *mem_ctx,
ret = sysdb_attrs_get_string_array(ipa_host, SYSDB_ORIG_MEMBEROF,
tmp_ctx, &memberof_list);
if (ret != EOK && ret != ENOENT) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Could not identify ");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Could not identify \n");
} if (ret == ENOENT) {
/* This host is not a member of any hostgroups */
memberof_list = talloc_array(tmp_ctx, const char *, 1);
diff --git a/src/providers/ipa/ipa_hostid.c b/src/providers/ipa/ipa_hostid.c
index
6b8233587925b87ae89ec1975d1cc933b8643fb4..31fa29f91e72f8f55ad20e45fc23b7279e785889
100644
--- a/src/providers/ipa/ipa_hostid.c
+++ b/src/providers/ipa/ipa_hostid.c
@@ -110,7 +110,7 @@ ipa_host_info_complete(struct be_req *breq, int dp_error,
error_text = NULL;
} else {
DEBUG(SSSDBG_CRIT_FAILURE,
- "Bug: dp_error is OK on failed request");
+ "Bug: dp_error is OK on failed request\n");
dp_error = DP_ERR_FATAL;
error_text = default_error_text;
}
diff --git a/src/providers/ipa/ipa_selinux.c b/src/providers/ipa/ipa_selinux.c
index
133b679b6d518704ebb2bd901c64ac48170c9a0b..f7e17c97f0bf8d6c64eb045c3bc954da8eb3d568
100644
--- a/src/providers/ipa/ipa_selinux.c
+++ b/src/providers/ipa/ipa_selinux.c
@@ -211,7 +211,7 @@ done:
if (in_transaction) {
sret = sysdb_transaction_cancel(sysdb);
if (sret != EOK) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Failed to cancel transaction");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Failed to cancel transaction\n");
}
}
return ret;
@@ -788,7 +788,7 @@ static errno_t choose_best_seuser(TALLOC_CTX *mem_ctx,
ret = selinux_child_setup(tmp_ctx, pd->user, user_domain, seuser_mls_str,
&sci);
if (ret != EOK) {
- DEBUG(SSSDBG_OP_FAILURE, "Cannot set up child input buffer");
+ DEBUG(SSSDBG_OP_FAILURE, "Cannot set up child input buffer\n");
goto done;
}
@@ -865,7 +865,7 @@ selinux_child_setup(TALLOC_CTX *mem_ctx,
}
} else {
DEBUG(SSSDBG_OP_FAILURE,
- "sss_parse_name failed: [%d] %s", ret, sss_strerror(ret));
+ "sss_parse_name failed: [%d] %s\n", ret, sss_strerror(ret));
goto done;
}
} else {
diff --git a/src/providers/ipa/ipa_subdomains.c
b/src/providers/ipa/ipa_subdomains.c
index
d0f02badee52afc93eb9bf316e654aa0e789937a..0fe2a8dd600fee44c5ab27b664dd47b1cb045dc9
100644
--- a/src/providers/ipa/ipa_subdomains.c
+++ b/src/providers/ipa/ipa_subdomains.c
@@ -1658,17 +1658,17 @@ int ipa_subdom_init(struct be_ctx *be_ctx,
NULL);
if (ret != EOK) {
DEBUG(SSSDBG_MINOR_FAILURE,
- "Failed to add subdom reset timeouts callback");
+ "Failed to add subdom reset timeouts callback\n");
}
ret = be_add_online_cb(ctx, be_ctx, ipa_subdom_online_cb, ctx, NULL);
if (ret != EOK) {
- DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom online callback");
+ DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom online callback\n");
}
ret = be_add_offline_cb(ctx, be_ctx, ipa_subdom_offline_cb, ctx, NULL);
if (ret != EOK) {
- DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom offline callback");
+ DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom offline callback\n");
}
ret = ipa_subdom_reinit(ctx);
diff --git a/src/providers/ipa/ipa_subdomains_ext_groups.c
b/src/providers/ipa/ipa_subdomains_ext_groups.c
index
b9690bdb682a9348340d22d4b24f0f284671610d..ad278b248ec2a2a157fed0a455dbe97049e83f9d
100644
--- a/src/providers/ipa/ipa_subdomains_ext_groups.c
+++ b/src/providers/ipa/ipa_subdomains_ext_groups.c
@@ -847,9 +847,9 @@ static void ipa_add_ad_memberships_get_next(struct
tevent_req *req)
}
if (missing_groups) {
- DEBUG(SSSDBG_CRIT_FAILURE, "There are unresolved external group " \
- "memberships even after all groups
have " \
- "been looked up on the LDAP server.");
+ DEBUG(SSSDBG_CRIT_FAILURE,
+ "There are unresolved external group memberships even after "
+ "all groups have been looked up on the LDAP server.\n");
}
tevent_req_done(req);
return;
diff --git a/src/providers/krb5/krb5_child.c b/src/providers/krb5/krb5_child.c
index
8b3f10d8244f483e6f99a79b01964b0018fa3ee4..0fcec981633989593d7155a57811d02a997db251
100644
--- a/src/providers/krb5/krb5_child.c
+++ b/src/providers/krb5/krb5_child.c
@@ -915,7 +915,7 @@ done:
}
if (krb5_kt_close(kr->ctx, keytab) != 0) {
- DEBUG(SSSDBG_MINOR_FAILURE, "krb5_kt_close failed");
+ DEBUG(SSSDBG_MINOR_FAILURE, "krb5_kt_close failed\n");
}
if (validation_princ != NULL) {
krb5_free_principal(kr->ctx, validation_princ);
diff --git a/src/providers/krb5/krb5_wait_queue.c
b/src/providers/krb5/krb5_wait_queue.c
index
3c390531eacc2db01796135c384acd494b3c919d..10c50d81b8c8b81aab0b5f73fa86b57f708a2e54
100644
--- a/src/providers/krb5/krb5_wait_queue.c
+++ b/src/providers/krb5/krb5_wait_queue.c
@@ -84,7 +84,7 @@ errno_t add_to_wait_queue(struct be_req *be_req, struct
pam_data *pd,
&krb5_ctx->wait_queue_hash, 0, 0, 0, 0,
wait_queue_del_cb, NULL);
if (ret != EOK) {
- DEBUG(SSSDBG_CRIT_FAILURE, "sss_hash_create failed");
+ DEBUG(SSSDBG_CRIT_FAILURE, "sss_hash_create failed\n");
return ret;
}
}
diff --git a/src/providers/ldap/ldap_id.c b/src/providers/ldap/ldap_id.c
index
5ce462d77867f115fe5c0214fcb95b72a4370472..af90fd06154fedd655de525d040ec24dd6ede3cc
100644
--- a/src/providers/ldap/ldap_id.c
+++ b/src/providers/ldap/ldap_id.c
@@ -1639,7 +1639,7 @@ static void sdap_account_info_complete(struct tevent_req
*req)
error_text = NULL;
} else {
DEBUG(SSSDBG_CRIT_FAILURE,
- "Bug: dp_error is OK on failed request");
+ "Bug: dp_error is OK on failed request\n");
dp_error = DP_ERR_FATAL;
error_text = req_error_text;
}
diff --git a/src/providers/ldap/sdap.c b/src/providers/ldap/sdap.c
index
c401e7dc86ded8b3685862c6528034b5cc55068d..bae7d02c5b6dbf736ac8826d58b497efc7e4acec
100644
--- a/src/providers/ldap/sdap.c
+++ b/src/providers/ldap/sdap.c
@@ -437,7 +437,7 @@ int sdap_parse_entry(TALLOC_CTX *memctx,
if (!vals) {
ldap_get_option(sh->ldap, LDAP_OPT_RESULT_CODE, &lerrno);
if (lerrno != LDAP_SUCCESS) {
- DEBUG(SSSDBG_CRIT_FAILURE, "LDAP Library error: %d(%s)",
+ DEBUG(SSSDBG_CRIT_FAILURE, "LDAP Library error: %d(%s)\n",
lerrno, sss_ldap_err2string(lerrno));
ret = EIO;
goto done;
@@ -517,7 +517,7 @@ int sdap_parse_entry(TALLOC_CTX *memctx,
ldap_get_option(sh->ldap, LDAP_OPT_RESULT_CODE, &lerrno);
if (lerrno) {
- DEBUG(SSSDBG_CRIT_FAILURE, "LDAP Library error: %d(%s)",
+ DEBUG(SSSDBG_CRIT_FAILURE, "LDAP Library error: %d(%s)\n",
lerrno, sss_ldap_err2string(lerrno));
ret = EIO;
goto done;
diff --git a/src/providers/ldap/sdap_access.c b/src/providers/ldap/sdap_access.c
index
e09e6b8fe55e8e8bae9ff7f46e815595cb938971..a6c882cae634f080b200fe75f51867e39192bcd9
100644
--- a/src/providers/ldap/sdap_access.c
+++ b/src/providers/ldap/sdap_access.c
@@ -276,7 +276,7 @@ static void sdap_access_done(struct tevent_req *subreq)
break;
default:
ret = EINVAL;
- DEBUG(SSSDBG_MINOR_FAILURE, "Unknown access control type: %d.",
+ DEBUG(SSSDBG_MINOR_FAILURE, "Unknown access control type: %d.\n",
state->ac_type);
break;
}
diff --git a/src/providers/ldap/sdap_async.c b/src/providers/ldap/sdap_async.c
index
a6954620bd0f27b5f2d2e45563af9d1440d9cf7c..c30a4578e01085daeca1ccc9cc54083513acc4de
100644
--- a/src/providers/ldap/sdap_async.c
+++ b/src/providers/ldap/sdap_async.c
@@ -1481,7 +1481,7 @@ static void sdap_get_generic_op_finished(struct sdap_op
*op,
&total_count, &cookie);
ldap_controls_free(returned_controls);
if (lret != LDAP_SUCCESS) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Could not determine page control");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Could not determine page control\n");
tevent_req_error(req, EIO);
return;
}
diff --git a/src/providers/ldap/sdap_async_connection.c
b/src/providers/ldap/sdap_async_connection.c
index
304505458135ba1f65e2e89e066bf68291435ba1..bc03a87a2f806bf80d72bc0414c37da62135de9a
100644
--- a/src/providers/ldap/sdap_async_connection.c
+++ b/src/providers/ldap/sdap_async_connection.c
@@ -1792,7 +1792,7 @@ static void sdap_cli_auth_step(struct tevent_req *req)
ret = sdap_cli_auth_reconnect(req);
if (ret != EOK) {
DEBUG(SSSDBG_MINOR_FAILURE,
- "sdap_cli_auth_reconnect failed: %d:[%s]",
+ "sdap_cli_auth_reconnect failed: %d:[%s]\n",
ret, sss_strerror(ret));
tevent_req_error(req, ret);
}
diff --git a/src/providers/ldap/sdap_async_initgroups.c
b/src/providers/ldap/sdap_async_initgroups.c
index
6b3179d2d6bb30b3b00aa35b07da42de3cf08a34..48c16b71637f83399d9a523f64f6d812b91681ef
100644
--- a/src/providers/ldap/sdap_async_initgroups.c
+++ b/src/providers/ldap/sdap_async_initgroups.c
@@ -1792,7 +1792,7 @@ static void sdap_initgr_rfc2307bis_done(struct tevent_req
*subreq)
ret = save_rfc2307bis_groups(state);
if (ret != EOK) {
DEBUG(SSSDBG_MINOR_FAILURE,
- "Could not save groups memberships [%d]", ret);
+ "Could not save groups memberships [%d]\n", ret);
goto fail;
}
@@ -1800,7 +1800,7 @@ static void sdap_initgr_rfc2307bis_done(struct tevent_req
*subreq)
ret = save_rfc2307bis_group_memberships(state);
if (ret != EOK) {
DEBUG(SSSDBG_MINOR_FAILURE,
- "Could not save group memberships [%d]", ret);
+ "Could not save group memberships [%d]\n", ret);
goto fail;
}
@@ -1808,7 +1808,7 @@ static void sdap_initgr_rfc2307bis_done(struct tevent_req
*subreq)
ret = save_rfc2307bis_user_memberships(state);
if (ret != EOK) {
DEBUG(SSSDBG_MINOR_FAILURE,
- "Could not save user memberships [%d]", ret);
+ "Could not save user memberships [%d]\n", ret);
goto fail;
}
diff --git a/src/providers/ldap/sdap_utils.c b/src/providers/ldap/sdap_utils.c
index
93a1faae10e5623e35b70269b924ba269b6f8e43..f5ce8ee54f60a6c4c4cdbd5e50b20d973c175e83
100644
--- a/src/providers/ldap/sdap_utils.c
+++ b/src/providers/ldap/sdap_utils.c
@@ -86,7 +86,7 @@ sdap_save_all_names(const char *name,
ret = sysdb_attrs_get_aliases(tmp_ctx, ldap_attrs, name,
lowercase, &aliases);
if (ret != EOK) {
- DEBUG(SSSDBG_OP_FAILURE, "Failed to get the alias list");
+ DEBUG(SSSDBG_OP_FAILURE, "Failed to get the alias list\n");
goto done;
}
diff --git a/src/responder/autofs/autofssrv_cmd.c
b/src/responder/autofs/autofssrv_cmd.c
index
4c9f5cf7df091a7567107f08137f958fa191198c..797e638d53a8adbac658541496bd0ab85d271533
100644
--- a/src/responder/autofs/autofssrv_cmd.c
+++ b/src/responder/autofs/autofssrv_cmd.c
@@ -188,9 +188,9 @@ set_autofs_map(struct autofs_ctx *actx,
hret = hash_enter(actx->maps, &key, &value);
if (hret != EOK) {
DEBUG(SSSDBG_CRIT_FAILURE,
- "Unable to add hash table entry for [%s]", key.str);
+ "Unable to add hash table entry for [%s]\n", key.str);
DEBUG(SSSDBG_MINOR_FAILURE,
- "Hash error [%d][%s]", hret, hash_error_string(hret));
+ "Hash error [%d][%s]\n", hret, hash_error_string(hret));
return EIO;
}
talloc_steal(actx->maps, map);
diff --git a/src/responder/common/responder_dp.c
b/src/responder/common/responder_dp.c
index
df7455ce3ead4d84ff124ca54f5b74273c77a6d4..853b3eae3877a8b6b2ffb310a0fb9ccf017498ae
100644
--- a/src/responder/common/responder_dp.c
+++ b/src/responder/common/responder_dp.c
@@ -684,8 +684,8 @@ sss_dp_internal_get_send(struct resp_ctx *rctx,
ret = sss_dp_get_domain_conn(rctx, dom->conn_name, &be_conn);
if (ret != EOK) {
DEBUG(SSSDBG_CRIT_FAILURE,
- "BUG: The Data Provider connection for %s is not available!",
- dom->name);
+ "BUG: The Data Provider connection for %s is not available!\n",
+ dom->name);
ret = EIO;
goto error;
}
diff --git a/src/responder/nss/nsssrv_cmd.c b/src/responder/nss/nsssrv_cmd.c
index
1affde874d8b8e8798b3d195090139ba5a433ace..9c56096320f815e14f8c3e49223b7de29762a524
100644
--- a/src/responder/nss/nsssrv_cmd.c
+++ b/src/responder/nss/nsssrv_cmd.c
@@ -2858,8 +2858,8 @@ static int fill_grent(struct sss_packet *packet,
fullname.len - pwfield.len);
if (ret != EOK && ret != ENOMEM) {
DEBUG(SSSDBG_OP_FAILURE,
- "Failed to store group %s(%s) in mmap cache!",
- name.str, domain);
+ "Failed to store group %s(%s) in mmap cache!\n",
+ name.str, domain);
}
}
diff --git a/src/responder/nss/nsssrv_netgroup.c
b/src/responder/nss/nsssrv_netgroup.c
index
66b7f2759c88e8279747d59d2ec4c83ada8a21ba..c71043858988bbf6c66aaab1357d24d3701c777f
100644
--- a/src/responder/nss/nsssrv_netgroup.c
+++ b/src/responder/nss/nsssrv_netgroup.c
@@ -76,9 +76,9 @@ static errno_t set_netgroup_entry(struct nss_ctx *nctx,
hret = hash_enter(nctx->netgroups, &key, &value);
if (hret != EOK) {
DEBUG(SSSDBG_FATAL_FAILURE,
- "Unable to add hash table entry for [%s]", key.str);
+ "Unable to add hash table entry for [%s]\n", key.str);
DEBUG(SSSDBG_CONF_SETTINGS,
- "Hash error [%d][%s]", hret, hash_error_string(hret));
+ "Hash error [%d][%s]\n", hret, hash_error_string(hret));
return EIO;
}
talloc_steal(nctx->netgroups, netgr);
diff --git a/src/responder/pac/pacsrv_cmd.c b/src/responder/pac/pacsrv_cmd.c
index
07d2f0cf79b70429dc7cf2784a8e31d651e5095f..596a32dc8b34fc125903f3b2ce5071a1745183f0
100644
--- a/src/responder/pac/pacsrv_cmd.c
+++ b/src/responder/pac/pacsrv_cmd.c
@@ -131,7 +131,7 @@ static errno_t pac_add_pac_user(struct cli_ctx *cctx)
pr_ctx->domain_name = pr_ctx->logon_info->info3.base.logon_domain.string;
if (pr_ctx->domain_name == NULL) {
- DEBUG(SSSDBG_FATAL_FAILURE, "No domain name in PAC");
+ DEBUG(SSSDBG_FATAL_FAILURE, "No domain name in PAC\n");
ret = EINVAL;
goto done;
}
@@ -584,15 +584,13 @@ static errno_t save_pac_user(struct pac_req_ctx *pr_ctx)
&msg);
if (ret == ENOENT) {
if (pwd->pw_gid == 0 && !pr_ctx->dom->mpg) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Primary group RID from the PAC " \
- "cannot be translated into a GID for "
\
- "user [%s]. Typically this happens " \
- "when UIDs and GIDs are read from AD "
\
- "and the primary AD group does not " \
- "have a GID assigned. Make sure the " \
- "user is created by the ID provider " \
- "before GSSAPI based authentication " \
- "is used in this case.", pwd->pw_name);
+ DEBUG(SSSDBG_CRIT_FAILURE,
+ "Primary group RID from the PAC cannot be translated into "
+ "a GID for user [%s]. Typically this happens when UIDs and "
+ "GIDs are read from AD and the primary AD group does not "
+ "have a GID assigned. Make sure the user is created by the "
+ "ID provider before GSSAPI based authentication "
+ "is used in this case.\n", pwd->pw_name);
ret = EINVAL;
goto done;
}
diff --git a/src/responder/pac/pacsrv_utils.c b/src/responder/pac/pacsrv_utils.c
index
7d37cda87ab4a5c233474beb67d91aa03c939b72..de2e8dfbd4e6c08cf67da4f4e252af694d030f1e
100644
--- a/src/responder/pac/pacsrv_utils.c
+++ b/src/responder/pac/pacsrv_utils.c
@@ -433,8 +433,8 @@ errno_t get_pwd_from_pac(TALLOC_CTX *mem_ctx,
goto done;
}
} else {
- DEBUG(SSSDBG_OP_FAILURE, "Missing full name in PAC, "
- "gecos field will by empty.\n ");
+ DEBUG(SSSDBG_OP_FAILURE,
+ "Missing full name in PAC, gecos field will by empty.\n");
}
/* Check if there is a special homedir template for sub-domains. If not a
diff --git a/src/responder/pam/pamsrv.c b/src/responder/pam/pamsrv.c
index
886136b420b6184a86ce6e0d9ac84dd3dea9a94b..45747baa03b593a65e70f4cbd0ce022648d1333c
100644
--- a/src/responder/pam/pamsrv.c
+++ b/src/responder/pam/pamsrv.c
@@ -278,8 +278,8 @@ static int pam_process_init(TALLOC_CTX *mem_ctx,
ret = sss_hash_create(pctx, 10, &pctx->id_table);
if (ret != EOK) {
DEBUG(SSSDBG_FATAL_FAILURE,
- "Could not create initgroups hash table: [%s]",
- strerror(ret));
+ "Could not create initgroups hash table: [%s]\n",
+ strerror(ret));
goto done;
}
diff --git a/src/responder/sudo/sudosrv_get_sudorules.c
b/src/responder/sudo/sudosrv_get_sudorules.c
index
ac95877143e210da962a47143c18733eecdc9c02..34d63bd74741c3cab5168fd0b0108cb05528d218
100644
--- a/src/responder/sudo/sudosrv_get_sudorules.c
+++ b/src/responder/sudo/sudosrv_get_sudorules.c
@@ -664,7 +664,7 @@ static errno_t sudosrv_get_sudorules_query_cache(TALLOC_CTX
*mem_ctx,
SUDORULE_SUBDIR, attrs,
&count, &msgs);
if (ret != EOK && ret != ENOENT) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Error looking up SUDO rules");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Error looking up SUDO rules\n");
goto done;
} if (ret == ENOENT) {
*_rules = NULL;
diff --git a/src/responder/sudo/sudosrv_query.c
b/src/responder/sudo/sudosrv_query.c
index
4d19514cd63f432d7cee2bbfbece237fb56c5dec..4cb07e32b3d7f2897dcd7f4941aa44bf8928d5c2
100644
--- a/src/responder/sudo/sudosrv_query.c
+++ b/src/responder/sudo/sudosrv_query.c
@@ -109,7 +109,7 @@ static int sudosrv_response_append_attr(TALLOC_CTX *mem_ctx,
/* values */
for (i = 0; i < values_num; i++) {
if (strlen((char*)(values[i].data)) != values[i].length) {
- DEBUG(SSSDBG_CRIT_FAILURE, "value is not a string");
+ DEBUG(SSSDBG_CRIT_FAILURE, "value is not a string\n");
ret = EINVAL;
goto done;
}
diff --git a/src/sbus/sssd_dbus_server.c b/src/sbus/sssd_dbus_server.c
index
1375248923525e9afcf3ad380fedff0e9ae2badb..0a1cace415b3514a6904e92a2d879538ce51a593
100644
--- a/src/sbus/sssd_dbus_server.c
+++ b/src/sbus/sssd_dbus_server.c
@@ -56,7 +56,7 @@ static void sbus_server_init_new_connection(DBusServer
*dbus_server,
SBUS_CONN_TYPE_PRIVATE, &conn);
if (ret != 0) {
dbus_connection_close(dbus_conn);
- DEBUG(SSSDBG_FUNC_DATA,"Closing connection (failed setup)");
+ DEBUG(SSSDBG_FUNC_DATA, "Closing connection (failed setup)\n");
return;
}
@@ -145,7 +145,7 @@ remove_socket_symlink(const char *symlink_name)
ret = snprintf(pidpath, PATH_MAX, "%s.%lu",
symlink_name, (unsigned long) getpid());
if (ret < 0) {
- DEBUG(SSSDBG_OP_FAILURE, "snprintf failed");
+ DEBUG(SSSDBG_OP_FAILURE, "snprintf failed\n");
return EIO;
} else if (ret >= PATH_MAX) {
DEBUG(SSSDBG_OP_FAILURE, "path too long?!?!\n");
diff --git a/src/tests/krb5_child-test.c b/src/tests/krb5_child-test.c
index
a59863b4d8aa8bdcc241c87befd672a5e5c876a3..50acc88ed0c312b2662f01fe41247781f235a54d
100644
--- a/src/tests/krb5_child-test.c
+++ b/src/tests/krb5_child-test.c
@@ -73,7 +73,7 @@ setup_krb5_child_test(TALLOC_CTX *mem_ctx, struct
krb5_child_test_ctx **_ctx)
ctx->ev = tevent_context_init(ctx);
if (ctx->ev == NULL) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Could not init tevent context");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Could not init tevent context\n");
talloc_free(ctx);
return EFAULT;
}
diff --git a/src/tools/files.c b/src/tools/files.c
index
f1cede0cee3b7096b76c88b8cd6e717007b692a1..5b3f9d103120aa5c06d9a453b279aca19258947d
100644
--- a/src/tools/files.c
+++ b/src/tools/files.c
@@ -516,7 +516,7 @@ copy_entry(struct copy_ctx *cctx,
if (ret != 0) {
ret = errno;
DEBUG(SSSDBG_CRIT_FAILURE,
- "couldn't stat '%s': %s", src_ent_path, strerror(ret));
+ "couldn't stat '%s': %s\n", src_ent_path, strerror(ret));
goto done;
}
@@ -577,7 +577,7 @@ copy_dir(struct copy_ctx *cctx,
if (dir == NULL) {
ret = errno;
DEBUG(SSSDBG_CRIT_FAILURE,
- "Error reading '%s': %s", src_dir_path, strerror(ret));
+ "Error reading '%s': %s\n", src_dir_path, strerror(ret));
goto done;
}
@@ -590,7 +590,7 @@ copy_dir(struct copy_ctx *cctx,
if (ret == -1 && errno != EEXIST) {
ret = errno;
DEBUG(SSSDBG_CRIT_FAILURE,
- "Error reading '%s': %s", dest_dir_path, strerror(ret));
+ "Error reading '%s': %s\n", dest_dir_path, strerror(ret));
goto done;
}
@@ -599,7 +599,7 @@ copy_dir(struct copy_ctx *cctx,
if (dest_dir_fd == -1) {
ret = errno;
DEBUG(SSSDBG_CRIT_FAILURE,
- "Error opening '%s': %s", dest_dir_path, strerror(ret));
+ "Error opening '%s': %s\n", dest_dir_path, strerror(ret));
goto done;
}
@@ -628,7 +628,7 @@ copy_dir(struct copy_ctx *cctx,
if (ret == -1 && errno != EPERM) {
ret = errno;
DEBUG(SSSDBG_OP_FAILURE,
- "Error changing owner of '%s': %s",
+ "Error changing owner of '%s': %s\n",
dest_dir_path, strerror(ret));
goto done;
}
@@ -640,7 +640,7 @@ copy_dir(struct copy_ctx *cctx,
if (ret == -1) {
ret = errno;
DEBUG(SSSDBG_OP_FAILURE,
- "Error setting mode of '%s': %s",
+ "Error setting mode of '%s': %s\n",
dest_dir_path, strerror(ret));
goto done;
}
diff --git a/src/tools/sss_cache.c b/src/tools/sss_cache.c
index
e6faf2d745c011c6c378f426adee040e25e13f1a..c9bf2491490032cef23e4686aab59391daaa621c
100644
--- a/src/tools/sss_cache.c
+++ b/src/tools/sss_cache.c
@@ -426,15 +426,16 @@ static bool invalidate_entries(TALLOC_CTX *ctx,
c_name = ldb_msg_find_attr_as_string(msgs[i], SYSDB_NAME, NULL);
if (c_name == NULL) {
DEBUG(SSSDBG_MINOR_FAILURE,
- "Something bad happened, can't find attribute %s",
SYSDB_NAME);
- ERROR("Couldn't invalidate %1$s", type_string);
+ "Something bad happened, can't find attribute %s\n",
+ SYSDB_NAME);
+ ERROR("Couldn't invalidate %1$s\n", type_string);
iret = false;
} else {
ret = invalidate_entry(ctx, dinfo, c_name, entry_type);
if (ret != EOK) {
DEBUG(SSSDBG_MINOR_FAILURE,
- "Couldn't invalidate %s %s", type_string, c_name);
- ERROR("Couldn't invalidate %1$s %2$s", type_string, c_name);
+ "Couldn't invalidate %s %s\n", type_string, c_name);
+ ERROR("Couldn't invalidate %1$s %2$s\n", type_string, c_name);
iret = false;
}
}
diff --git a/src/tools/sss_sync_ops.c b/src/tools/sss_sync_ops.c
index
fd401cb4da491b1d996178312d5ff69d3a461bfc..e6faedcae556b3c55a7d267b429eed46076119c9
100644
--- a/src/tools/sss_sync_ops.c
+++ b/src/tools/sss_sync_ops.c
@@ -40,7 +40,7 @@
#define VAR_CHECK(var, val, attr, msg) do { \
if (var != (val)) { \
- DEBUG(SSSDBG_CRIT_FAILURE, msg" attribute: %s", attr); \
+ DEBUG(SSSDBG_CRIT_FAILURE, msg" attribute: %s\n", attr); \
return val; \
} \
} while(0)
diff --git a/src/util/debug.c b/src/util/debug.c
index
41375709170abe33b0c7fd90e3b1244299ed0241..3121c70b17a4c996da143b2ffa449b686b57fab4
100644
--- a/src/util/debug.c
+++ b/src/util/debug.c
@@ -431,5 +431,5 @@ int rotate_debug_files(void)
void talloc_log_fn(const char *message)
{
- DEBUG(SSSDBG_FATAL_FAILURE, "%s", message);
+ DEBUG(SSSDBG_FATAL_FAILURE, "%s\n", message);
}
diff --git a/src/util/domain_info_utils.c b/src/util/domain_info_utils.c
index
e0f1120e3c96757b0ad623b7dd6d43af2e643589..e76c1cefb49334bf70ef9709b3986134f7ef565c
100644
--- a/src/util/domain_info_utils.c
+++ b/src/util/domain_info_utils.c
@@ -433,8 +433,9 @@ sss_write_domain_mappings(struct sss_domain_info *domain)
fd = mkstemp(tmp_file);
umask(old_mode);
if (fd < 0) {
- DEBUG(SSSDBG_OP_FAILURE, "creating the temp file [%s] for domain-realm
"
- "mappings failed.", tmp_file);
+ DEBUG(SSSDBG_OP_FAILURE,
+ "creating the temp file [%s] for domain-realm mappings failed\n",
+ tmp_file);
ret = EIO;
talloc_zfree(tmp_ctx);
goto done;
@@ -567,8 +568,8 @@ done:
if (err < 0) {
err = errno;
DEBUG(SSSDBG_MINOR_FAILURE,
- "Could not remove file [%s]: [%d]: %s",
- tmp_file, err, strerror(err));
+ "Could not remove file [%s]: [%d]: %s\n",
+ tmp_file, err, strerror(err));
}
}
talloc_free(tmp_ctx);
@@ -682,8 +683,9 @@ static errno_t sss_write_krb5_localauth_snippet(const char
*path)
fd = mkstemp(tmp_file);
umask(old_mode);
if (fd < 0) {
- DEBUG(SSSDBG_OP_FAILURE, "creating the temp file [%s] for domain-realm
"
- "mappings failed.", tmp_file);
+ DEBUG(SSSDBG_OP_FAILURE,
+ "creating the temp file [%s] for domain-realm mappings failed\n",
+ tmp_file);
ret = EIO;
talloc_zfree(tmp_ctx);
goto done;
@@ -730,8 +732,8 @@ done:
if (err == -1) {
err = errno;
DEBUG(SSSDBG_MINOR_FAILURE,
- "Could not remove file [%s]: [%d]: %s",
- tmp_file, err, sss_strerror(err));
+ "Could not remove file [%s]: [%d]: %s\n",
+ tmp_file, err, sss_strerror(err));
}
}
diff --git a/src/util/find_uid.c b/src/util/find_uid.c
index
d0f76030d69e67d81abe5624d65b4261f8167cf4..535d8268ed3ee9c5531fdfe24e04231f2cbe93c5
100644
--- a/src/util/find_uid.c
+++ b/src/util/find_uid.c
@@ -74,7 +74,7 @@ static errno_t get_uid_from_pid(const pid_t pid, uid_t *uid)
ret = snprintf(path, PATHLEN, "/proc/%d/status", pid);
if (ret < 0) {
- DEBUG(SSSDBG_CRIT_FAILURE, "snprintf failed");
+ DEBUG(SSSDBG_CRIT_FAILURE, "snprintf failed\n");
return EINVAL;
} else if (ret >= PATHLEN) {
DEBUG(SSSDBG_CRIT_FAILURE, "path too long?!?!\n");
diff --git a/src/util/server.c b/src/util/server.c
index
abd29310f7b288b255176a0457f894f05b485df6..7e9b76f74ee5e76d2481eb425eff4811cc2e780e
100644
--- a/src/util/server.c
+++ b/src/util/server.c
@@ -350,8 +350,8 @@ int die_if_parent_died(void)
ret = prctl(PR_SET_PDEATHSIG, SIGTERM, 0, 0, 0);
if (ret != 0) {
ret = errno;
- DEBUG(SSSDBG_OP_FAILURE, "prctl failed [%d]: %s",
- ret, strerror(ret));
+ DEBUG(SSSDBG_OP_FAILURE, "prctl failed [%d]: %s\n",
+ ret, strerror(ret));
return ret;
}
#endif
diff --git a/src/util/sss_ini.c b/src/util/sss_ini.c
index
526ca31d414836bf83d12bcc81f535e7492df854..766a75ea6730b3a8f5fbec5f2086075fbcb2d81b
100644
--- a/src/util/sss_ini.c
+++ b/src/util/sss_ini.c
@@ -425,7 +425,7 @@ int sss_confdb_create_ldif(TALLOC_CTX *mem_ctx,
ldif_attr = talloc_asprintf(tmp_ctx,
"%s: %s\n", attrs[j], value);
- DEBUG(SSSDBG_TRACE_ALL, "%s", ldif_attr);
+ DEBUG(SSSDBG_TRACE_ALL, "%s\n", ldif_attr);
attr_len = strlen(ldif_attr);
@@ -455,7 +455,7 @@ int sss_confdb_create_ldif(TALLOC_CTX *mem_ctx,
dn[dn_size-1] = '\n';
dn[dn_size] = '\0';
- DEBUG(SSSDBG_TRACE_ALL, "Section dn\n%s", dn);
+ DEBUG(SSSDBG_TRACE_ALL, "Section dn\n%s\n", dn);
tmp_ldif = talloc_realloc(mem_ctx, ldif, char,
ldif_len+dn_size+1);
diff --git a/src/util/sss_krb5.c b/src/util/sss_krb5.c
index
447b5a5bc941c3ff0cf72fbaa0f2293dc4311194..e5c2121da575b174c8b6a9a90835f2c97f807f37
100644
--- a/src/util/sss_krb5.c
+++ b/src/util/sss_krb5.c
@@ -172,7 +172,7 @@ errno_t select_principal_from_keytab(TALLOC_CTX *mem_ctx,
if (_principal) {
kerr = krb5_unparse_name(krb_ctx, client_princ, &principal_string);
if (kerr) {
- DEBUG(SSSDBG_CRIT_FAILURE, "krb5_unparse_name failed");
+ DEBUG(SSSDBG_CRIT_FAILURE, "krb5_unparse_name failed\n");
ret = EFAULT;
goto done;
}
@@ -180,7 +180,7 @@ errno_t select_principal_from_keytab(TALLOC_CTX *mem_ctx,
*_principal = talloc_strdup(mem_ctx, principal_string);
free(principal_string);
if (!*_principal) {
- DEBUG(SSSDBG_CRIT_FAILURE, "talloc_strdup failed");
+ DEBUG(SSSDBG_CRIT_FAILURE, "talloc_strdup failed\n");
ret = ENOMEM;
goto done;
}
@@ -192,7 +192,7 @@ errno_t select_principal_from_keytab(TALLOC_CTX *mem_ctx,
KRB5_PRINCIPAL_UNPARSE_NO_REALM,
&principal_string);
if (kerr) {
- DEBUG(SSSDBG_CRIT_FAILURE, "krb5_unparse_name failed");
+ DEBUG(SSSDBG_CRIT_FAILURE, "krb5_unparse_name failed\n");
ret = EFAULT;
goto done;
}
@@ -200,7 +200,7 @@ errno_t select_principal_from_keytab(TALLOC_CTX *mem_ctx,
*_primary = talloc_strdup(mem_ctx, principal_string);
free(principal_string);
if (!*_primary) {
- DEBUG(SSSDBG_CRIT_FAILURE, "talloc_strdup failed");
+ DEBUG(SSSDBG_CRIT_FAILURE, "talloc_strdup failed\n");
if (_principal) talloc_zfree(*_principal);
ret = ENOMEM;
goto done;
@@ -223,7 +223,7 @@ errno_t select_principal_from_keytab(TALLOC_CTX *mem_ctx,
*_realm = talloc_asprintf(mem_ctx, "%.*s",
realm_len, realm_name);
if (!*_realm) {
- DEBUG(SSSDBG_CRIT_FAILURE, "talloc_asprintf failed");
+ DEBUG(SSSDBG_CRIT_FAILURE, "talloc_asprintf failed\n");
if (_principal) talloc_zfree(*_principal);
if (_primary) talloc_zfree(*_primary);
ret = ENOMEM;
diff --git a/src/util/sss_semanage.c b/src/util/sss_semanage.c
index
3c566553f2085a696f79c5ee35ec6015824d56a6..b85831c3d3f262f49b19082e96aa62ccf3afeaa8
100644
--- a/src/util/sss_semanage.c
+++ b/src/util/sss_semanage.c
@@ -326,8 +326,9 @@ int del_seuser(const char *login_name)
}
if (!exists) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Login mapping for %s is defined in policy,
"
- "cannot be deleted", login_name);
+ DEBUG(SSSDBG_CRIT_FAILURE,
+ "Login mapping for %s is defined in policy, cannot be deleted\n",
+ login_name);
ret = ENOENT;
goto done;
}
@@ -335,7 +336,7 @@ int del_seuser(const char *login_name)
ret = semanage_seuser_del_local(handle, key);
if (ret != 0) {
DEBUG(SSSDBG_CRIT_FAILURE,
- "Could not delete login mapping for %s", login_name);
+ "Could not delete login mapping for %s\n", login_name);
ret = EIO;
goto done;
}
diff --git a/src/util/usertools.c b/src/util/usertools.c
index
ebe139e6cd3c9eb270033629dab362fefb3e2682..439c1494ae5f4c8c46a7e36ad7c8af627ef83cdf
100644
--- a/src/util/usertools.c
+++ b/src/util/usertools.c
@@ -144,7 +144,7 @@ static errno_t sss_fqnames_init(struct sss_names_ctx *nctx,
const char *fq_fmt)
fq = sss_tc_fqname2 (nctx, nctx, "unused.example.com", "unused",
"the-test-user");
if (fq == NULL) {
DEBUG(SSSDBG_OP_FAILURE,
- "The fq format is invalid [%s]", nctx->fq_fmt);
+ "The fq format is invalid [%s]\n", nctx->fq_fmt);
return EINVAL;
} else if (strstr (fq, "the-test-user") == NULL) {
DEBUG(SSSDBG_OP_FAILURE,
--
2.1.0
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
