On Fri, Mar 06, 2015 at 12:50:28PM +0100, Pavel Reichl wrote: > On 03/06/2015 10:27 AM, Pavel Reichl wrote: > > > > > >On 03/06/2015 10:24 AM, Jakub Hrozek wrote: > >>On Thu, Mar 05, 2015 at 02:34:15PM +0100, Pavel Reichl wrote: > >>>>+ case PWP_SENTINEL: > >>>>+ default: > >>>>+ DEBUG(SSSDBG_MINOR_FAILURE, > >>>>+ "Unexpected value of password policy mode: %d.\n", > >>>>pwpol_mode); > >>>I guess it would be better to set 'ret = EINVAL;' here > >>Oops, yes. Can you send an additional patch for master along with the > >>sssd-1-12 rebase? > >>_______________________________________________ > >>sssd-devel mailing list > >>sssd-devel@lists.fedorahosted.org > >>https://lists.fedorahosted.org/mailman/listinfo/sssd-devel > >Sure, I'll do it now. > > > >BTW the list delay is starting to be a real annoyance. > >_______________________________________________ > >sssd-devel mailing list > >sssd-devel@lists.fedorahosted.org > >https://lists.fedorahosted.org/mailman/listinfo/sssd-devel > Master ci: > > http://sssd-ci.duckdns.org/logs/job/8/91/summary.html > > > 1-12 ci: > > http://sssd-ci.duckdns.org/logs/job/8/92/summary.html > >
> From 36adbcf7bfcb3dd38d4288f74c4c31ff98dc3b51 Mon Sep 17 00:00:00 2001 > From: Pavel Reichl <prei...@redhat.com> > Date: Fri, 6 Mar 2015 04:38:05 -0500 > Subject: [PATCH] SDAP: fix minor neglect in is_account_locked() ACK for master. Pushed as 79ee5fbacd6ee4153fa59edf5b1ae55b4f020211 > From d0676bee3a8a67321e81870ff142efb5d119c014 Mon Sep 17 00:00:00 2001 > From: Pavel Reichl <prei...@redhat.com> > Date: Tue, 20 Jan 2015 16:27:41 -0500 > Subject: [PATCH 1/3] UTIL: convert GeneralizedTime to unix time ACK, I just removed util.c from Makefile.am, just like I did in master. > From 105239ddc6cd2f5d0c50ec00d5cb05c9058dab0b Mon Sep 17 00:00:00 2001 > From: Pavel Reichl <prei...@redhat.com> > Date: Tue, 20 Jan 2015 18:34:44 -0500 > Subject: [PATCH 2/3] SDAP: Lock out ssh keys when account naturally expires > > Resolves: > https://fedorahosted.org/sssd/ticket/2534 ACK, I just removed util.c from Makefile.am, just like I did in master. > From 1f7d5182d6c6744e93ec47db6825a18da5e4d935 Mon Sep 17 00:00:00 2001 > From: Pavel Reichl <prei...@redhat.com> > Date: Fri, 6 Mar 2015 04:38:05 -0500 > Subject: [PATCH 3/3] SDAP: fix minor neglect in is_account_locked() > > It would be better to return explicit error code, although access is > still denied and error message printed. > > Relates: > https://fedorahosted.org/sssd/ticket/2534 ACK sssd-1-12 commits are: * 371c5f40199b6389bd3cbfd05654b2213caecfc1 * 8ebc05498460ce28eff012649c892b248c53632f * 3cace03ac7a2c4ff6d3469a3d3128c79a1882e43 _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
