On (29/05/15 19:35), Nikolai Kondrashov wrote: >Hi everyone, > >Sumit found that our cwrap tests are not running. After quick research I made >the attached patch fixing that. The regression was introduced by my >integration test patch. > >Nick
>From fd4804572c7f0b8d3757d6686ed518f9e6a6680a Mon Sep 17 00:00:00 2001 >From: Nikolai Kondrashov <[email protected]> >Date: Fri, 29 May 2015 19:23:00 +0300 >Subject: [PATCH] BUILD: Fix variable substitution in cwrap.m4 > >Add another dollar sign to have variable name substituted by m4 in >"cwrap.m4" further substituted with its value by shell in "configure". > >Before, this: > > [ test x$2 = xyes] > >would produce this in "configure" for uid_wrapper test: > > test xHAVE_UID_WRAPPER = xyes > >which is always false. > >Now the changed code: > > [ test x$$2 = xyes] > >Would produce this in "configure" instead: > > test x$HAVE_UID_WRAPPER = xyes > >which will properly process the test result. > >This fixes uid_wrapper and nss_wrapper detection, which were considered >missing otherwise, resulting in cwrap tests not running. >--- > src/external/cwrap.m4 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/src/external/cwrap.m4 b/src/external/cwrap.m4 >index b03d1ef..b8489cc 100644 >--- a/src/external/cwrap.m4 >+++ b/src/external/cwrap.m4 >@@ -16,7 +16,7 @@ AC_DEFUN([AM_CHECK_WRAPPER], > AC_MSG_WARN([cwrap library $1 not found, some tests > will not run]) > ]) > >- AM_CONDITIONAL($2, [ test x$2 = xyes]) >+ AM_CONDITIONAL($2, [ test x$$2 = xyes]) Yes, the same patter is in macro SSS_INTGCHECK_REQ Before patch: sh$ grep "^HAVE_.*_WRAPPER_TRUE" config.log HAVE_NSS_WRAPPER_TRUE='#' HAVE_UID_WRAPPER_TRUE='#' After patch: sh$ grep "^HAVE_.*_WRAPPER_TRUE" config.log HAVE_NSS_WRAPPER_TRUE='' HAVE_UID_WRAPPER_TRUE='' ACK http://sssd-ci.duckdns.org/logs/job/16/39/summary.html LS _______________________________________________ sssd-devel mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
