On Mon, Jun 08, 2015 at 04:34:07PM +0200, Michal Židek wrote: > On 06/05/2015 05:07 PM, Pavel Reichl wrote: > >On 06/05/2015 04:44 PM, Michal Židek wrote: > >>On 06/05/2015 01:33 PM, Pavel Reichl wrote: > >>>On 06/05/2015 01:17 PM, Michal Židek wrote: > >>>>On 05/28/2015 06:43 PM, Pavel Reichl wrote: > >>>>>Hello, > >>>>> > >>>>>please see simple attached patch. > >>>>> > >>>>>Thanks! > >>>>> > >>>>> > >>>> > >>>>Please send version that cleanly applies on top of current master. > >>>> > >>>>Michal > >>>> > >>>>_______________________________________________ > >>>>sssd-devel mailing list > >>>>[email protected] > >>>>https://lists.fedorahosted.org/mailman/listinfo/sssd-devel > >>>Hello, > >>> > >>>please see rebased patch attached. > >>> > >>>Thanks! > >>> > >> > >>Super small nitpick: > >> static errno_t > >> get_subdomain_homedir_of_user(TALLOC_CTX *mem_ctx, struct > >>sss_domain_info *dom, > >> const char *fqname, uint32_t uid, > >>- const char **_homedir) > >>+ const char* original, const char > >> ^^^^^ > >>Could you please move the '*' to the 'original' to look like > >>const char *original? > >Sure. > >> > >>The patch passed my testing. > >I suppose you have read the testing section from design document, right? > >>The only thing that did not work for me > >>was from sssd client when the server was not patched, but I think this > >>is expected (please confirm). > >I hereby confirm that this is expected behavior. > >> > >>I am waiting for the CI to finish. > >> > >>Michal > > Works as expected. From both server and client side. > > CI link: > http://sssd-ci.duckdns.org/logs/job/16/83/summary.html > _ ____ _ __ > / \ / ___| |/ / > / _ \| | | ' / > / ___ \ |___| . \ > /_/ \_\____|_|\_\
* master: 979e8d8d6ed444007eeff6be5269e8dc5d2bdf68 _______________________________________________ sssd-devel mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
