Hi! I think the function is a little overkill. The only change I would do in case of sss_cli commands is that I would change the decimal "%d" to a hexa "0x%x" because that matches the representation in the header and would simplify grepping the code.
OTOH if we want to make the messages also readable for the admins it makes sense to use the string representation. But I do not think it is that critical in case of sss_cli commands. But I am not strictly against this approach. Also you include util.h in the client code. This is something we want to avoid. If the function is really what we want and needs to be used in the client code as well, than it is good to create a small library that will link with the client code as well as the utils. Michal -- Senior Principal Intern _______________________________________________ sssd-devel mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
