On Wed, Jul 29, 2015 at 03:34:32PM +0200, Jakub Hrozek wrote: > On Tue, Jul 28, 2015 at 10:43:13PM +0200, Sumit Bose wrote: > > > > > > Hi, > > > > > > I started the review, but because the patches are quite big, I will send > > > my comments in batches. I hope that's fine. > > > > Thank you for the review. > > > > > > > > CI failed in distcheck. > > > > The failure was due to distcheck's tendency to make the complete source > > tree read-only and NSS's tendency open all databases in read-write more. > > I added the needed read-onl options to the NSS code. > > > > > > > > Coverity found some issues that I forwarded to Sumit. > > > > Thank you, I fixed them and hopefully did not create new ones. > > Coverity is clean this time, but CI did not pass on Debian due to build > failure of a test: > > http://sssd-ci.duckdns.org/logs/job/19/78/debian_testing/ci-build-debug/ci-make-tests.log > Normally this is caused by a missing dependency, which the Fedora/RHEL > linker can satisfy. > > I will review the rest of the patches.
I don't have any other comments. I tested authentication, password change and OTP authentication to exercise the PAM responder and pam_sss a bit and didn't find any issues. So ACK except the test build issue. Please let me know if you'd like me to help with that one. _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
