On 08/18/2015 01:35 PM, Jakub Hrozek wrote:
I wonder if it would be cleaner if there was a function that would accept a mem_ctx and line "syntax" and would create a sss_colondb_read_field* describing a line. Then sss_colondb_readline() would remove the talloc children first, then fill new data.Or even make the line syntax part of open? The usage could look like this: db = sss_colondb_open(mem_ctx, SSS_COLONDB_READ, "u:s:s:u"); whle (sss_colodb_readline(db, &line)) { } I think it would be nicer to have the line syntax part of open, because the line syntax can't change, it's a property of the file.
This is nice. Shall I create a ticket for it? I'd rather get those patches pushed and move to fqdn fix first, since this may take longer time to get done right.
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
